fix: Duplicated Query - b60ae773-9917-4bca-8a42-7cb45365a917.kql#720
Merged
Conversation
There is already a query that captures this regardless of if it is specialized workload or not.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to remove a duplicated query that was causing mis-association issues with Subscriptions, thereby avoiding potential conflicts in CxO. The key changes include:
- Removal of the duplicated query from the SAP KQL file.
- Replacement of the query code with a placeholder comment.
Comments suppressed due to low confidence (1)
azure-specialized-workloads/sap/kql/b60ae773-9917-4bca-8a42-7cb45365a917.kql:1
- [nitpick] The placeholder comment 'under-development' may lead to ambiguity regarding the intended state of this file. Consider either removing the file entirely if it is no longer needed or updating the comment to clearly indicate that the duplicated query has been removed.
// under-development
kpoineal
approved these changes
Apr 23, 2025
kpoineal
changed the title
tksh164
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This query was duplicated with this df0ff862-814d-45a3-95e4-4fad5a244ba6 from Compute/VirtualMachines and it was also incorrectly associated with Subscriptions.
Removing it to avoid issues in CxO.