Skip to content

fix: Exclude VMSS Flex with Standalone VMs and cleanup old workflow #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oZakari merged 6 commits into from
May 1, 2025
Merged

fix: Exclude VMSS Flex with Standalone VMs and cleanup old workflow #721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f81487d
fix: Exclude VMSS Flex with Standalone VMs
DaFitRobsta Apr 22, 2025
acb539d
fix: CoPilot suggestion to use tostring()
DaFitRobsta Apr 22, 2025
b657fe5
Merge branch 'main' into 40454---VMSS-Autoscale
tksh164 Apr 23, 2025
5340e84
Merge branch 'main' into 40454---VMSS-Autoscale
DaFitRobsta Apr 29, 2025
fa92de0
doc: Added additional description to KQL.
DaFitRobsta May 1, 2025
60102b1
Remove old build reccommendation workflow
oZakari May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 0 additions & 39 deletions .github/scripts/build-recommendation-object.ps1
View file
Open in desktop

This file was deleted.

99 changes: 0 additions & 99 deletions .github/workflows/build-recommendation-object.yml
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion azure-resources/Compute/virtualMachineScaleSets/kql/ee66ff65-9aa3-2345-93c1-25827cf79f44.kql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
// Azure Resource Graph Query
// Find VMSS instances associated with autoscale settings when autoscale is disabled
// Find VMSS instances (excluding VMSS Flex associated with standalone VMs) associated with autoscale settings when autoscale is disabled
resources
| where type == "microsoft.compute/virtualmachinescalesets"
| where isempty(tostring(tags['aks-managed-poolName']))
Copy link

Copilot AI May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a brief comment explaining why converting SKU to a string is required, to help future maintainers understand the data type assumptions in this query.

Suggested change
| where isempty(tostring(tags['aks-managed-poolName']))
| where isempty(tostring(tags['aks-managed-poolName']))
// Convert `sku` to a string to ensure consistent handling of its data type, as it might not always be a string.

Copilot uses AI. Check for mistakes.
| where isnotempty(tostring(sku))
| project name, id, tags
| join kind=leftouter (
resources
Expand Down