Skip to content

docs: Update recommendations.yaml for SQL MI DR#730

Merged
kpoineal merged 5 commits into
Azure:mainfrom
djordje-jeremic:djordje-jeremic-dr-patch-1
May 14, 2025
Merged

docs: Update recommendations.yaml for SQL MI DR#730
kpoineal merged 5 commits into
Azure:mainfrom
djordje-jeremic:djordje-jeremic-dr-patch-1

Conversation

@djordje-jeremic
Copy link
Copy Markdown
Contributor

Recommendation details revised by PG to align with definition in Supportability Hub.

Overview/Summary

Related Issues/Work Items

Breaking Changes

  1. Replace me
  2. Replace me

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Recommendation details revised by PG to align with definition in Supportability Hub.
Copilot AI review requested due to automatic review settings May 8, 2025 20:14
@djordje-jeremic djordje-jeremic requested a review from a team as a code owner May 8, 2025 20:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the recommendations for SQL Managed Instance disaster recovery to align with the definitions in the Supportability Hub.

  • Revised the recommendation description to “Enable cross region disaster recovery for SQL Managed Instance.”
  • Updated the potential benefits text for improved clarity and consistency.
  • Changed the learn more URL to point to the new instance failover groups page.

Comment thread azure-resources/Sql/managedInstances/recommendations.yaml Outdated
Comment thread azure-resources/Sql/managedInstances/recommendations.yaml Outdated
@tksh164 tksh164 changed the title Update recommendations.yaml for SQL MI DR docs: Update recommendations.yaml for SQL MI DR May 9, 2025
Copy link
Copy Markdown
Member

@tksh164 tksh164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments below.

Comment thread azure-resources/Sql/managedInstances/recommendations.yaml Outdated
djordje-jeremic and others added 2 commits May 9, 2025 08:06
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment thread azure-resources/Sql/managedInstances/recommendations.yaml Outdated
@djordje-jeremic
Copy link
Copy Markdown
Contributor Author

djordje-jeremic commented May 9, 2025

Thanks for your comments @tksh164, I believe I addressed them. If you are happy how it looks, please feel free to merge.

@kpoineal
Copy link
Copy Markdown
Contributor

kpoineal commented May 9, 2025

@djordje-jeremic It looks like the YAML linting is failing.

Can you please double check this? It looks like potentialBenefits is greater than 60 characters.

./azure-resources/Sql/managedInstances/recommendations.yaml: Error validating data './azure-resources/Sql/managedInstances/recommendations.yaml' with schema '.github/scripts/schemas/aprl-schema.yaml'
	3.potentialBenefits: Length of Enabling disaster recovery creates a continuously synchronized read-only secondary managed instance to support the primary instance. is greater than 60

You should just be able to update your branch that is associated with the Pull Request and the changes will get picked up when you push them.

@djordje-jeremic
Copy link
Copy Markdown
Contributor Author

@tksh164, @kpoineal The linting error addressed, feel free to merge.

@kpoineal kpoineal merged commit 3ea7820 into Azure:main May 14, 2025
10 checks passed
@djordje-jeremic djordje-jeremic deleted the djordje-jeremic-dr-patch-1 branch May 15, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants