fix: Rosanto - Quality Updates - May/2025#739
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines multiple Azure Resource Graph queries to leverage Advisor data, updates recommendation metadata for PostgreSQL and VM guidance, and standardizes projections across AKS agent pool queries.
- Switched NetApp and PostgreSQL queries to use
advisorresourcesjoins for more authoritative filtering. - Updated AKS recommendations to target
agentPools, set newrecommendationTypeIds, and include tags in projections. - Refactored VM recommendations: assigned new IDs, cleaned up disabled entries, adjusted impact levels, and revamped capacity reservation logic.
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| azure-resources/NetApp/netAppAccounts/kql/e3d742e1-dacd-9b48-b6b1-510ec9f87c96.kql | Switched to advisorresources join and updated projection |
| azure-resources/NetApp/netAppAccounts/kql/72827434-c773-4345-9493-34848ddf5803.kql | Switched to advisorresources join and updated projection |
| azure-resources/DBforPostgreSQL/flexibleServers/recommendations.yaml | Set recommendationTypeId for geo redundant backup |
| azure-resources/DBforPostgreSQL/flexibleServers/kql/31f4ac4b-29cb-4588-8de2-d8fe6f13ceb3.kql | Migrated backup storage query to advisorresources join |
| azure-resources/ContainerService/managedClusters/recommendations.yaml | Updated recommendationTypeIds, resourceType to agentPools, toggled metadata states |
| azure-resources/ContainerService/managedClusters/kql/f46b0d1d-56ef-4795-b98a-f6ee00cb341a.kql | Standardized projections to include tags and full agentPool path |
| azure-resources/ContainerService/managedClusters/kql/e620fa98-7a40-41a0-bfc9-b4407297fb58.kql | Adjusted filter operator, added tags, refined join logic |
| azure-resources/ContainerService/managedClusters/kql/dcaf8128-94bd-4d53-9235-3a0371df6b74.kql | Aligned project order and included tags |
| azure-resources/ContainerService/managedClusters/kql/a7bfcc18-b0d8-4d37-81f3-8131ed8bead5.kql | Updated projection to include tags and full agentPool path |
| azure-resources/ContainerService/managedClusters/kql/7f7ae535-a5ba-4665-b7e0-c451dbdda01f.kql | Updated projection to include tags |
| azure-resources/ContainerService/managedClusters/kql/5f3cbd68-692a-4121-988c-9770914859a9.kql | Updated projection to include tags |
| azure-resources/ContainerService/managedClusters/kql/5ee083cd-6ac3-4a83-8913-9549dd36cf56.kql | Reordered project fields |
| azure-resources/ContainerService/managedClusters/kql/4f63619f-5001-439c-bacb-8de891287727.kql | Adjusted header comment and updated project to agentPool path |
| azure-resources/ContainerService/managedClusters/kql/26ebaf1f-c70d-4ebd-8641-4b60a0ce0094.kql | Reordered project fields |
| azure-resources/ContainerService/managedClusters/kql/0611251f-e70f-4243-8ddd-cfe894bec2e7.kql | Reordered project fields |
| azure-resources/ContainerService/managedClusters/kql/005ccbbd-aeab-46ef-80bd-9bd4479412ec.kql | Updated projection to include tags and full agentPool path |
| azure-resources/Compute/virtualMachines/recommendations.yaml | Added new IDs, cleaned up disabled entries, updated impacts and descriptions |
| azure-resources/Compute/virtualMachines/kql/73d1bb04-7d3e-0d47-bc0d-63afe773b5fe.kql | Added ARG query for Accelerated Networking validation |
| azure-resources/Compute/virtualMachines/kql/52ab9e5c-eec0-3148-8bd7-b6dd9e1be870.kql | Refactored maintenance configuration query with join |
| azure-resources/Compute/virtualMachines/kql/302fda08-ee65-4fbe-a916-6dc0b33169c4.kql | Refactored capacity reservation query to use advisorresources join |
Comments suppressed due to low confidence (2)
azure-resources/Compute/virtualMachines/recommendations.yaml:207
- Missing recommendationTypeId: please set this to the GUID used in the corresponding KQL to ensure metadata and query linkage.
recommendationTypeId: null
azure-resources/Compute/virtualMachines/kql/302fda08-ee65-4fbe-a916-6dc0b33169c4.kql:13
- The query no longer includes the zone information (param3) that was in the original version. Consider adding a 'Zone' parameter to match the intended output.
| project recommendationId = "302fda08-ee65-4fbe-a916-6dc0b33169c4", name , id = resId, tags,param1 = properties.hardwareProfile.vmSize, param2 = location
…7a40-41a0-bfc9-b4407297fb58.kql Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
kpoineal
changed the title
added 2 commits
May 21, 2025 11:57
…e/Azure-Proactive-Resiliency-Library-v2 into rosanto-may-quality-updates
kpoineal
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Fixes:
Microsoft.ContainerService/managedClusters/agentPools
aprlGuid: 005ccbbd-aeab-46ef-80bd-9bd4479412ec - description: Configure user nodepool count
aprlGuid: 4f63619f-5001-439c-bacb-8de891287727 - Deploy AKS cluster across availability zones
aprlGuid: a7bfcc18-b0d8-4d37-81f3-8131ed8bead5 - Use Ephemeral OS disks on AKS clusters
Added a more specific resource type to the recommendation
Updated query to project more specific resourceId
microsoft.netapp/netappaccounts/capacitypools/volumes/
Advisor 7a48f43e-8615-4ce0-8039-83b9d24f945a - Create a cross-zone replication relationship from the Azure NetApp Files volume to another volume
Bug filed to Advisor team to change Change ResourceType to a more specific type
Association between APRL e3d742e1-dacd-9b48-b6b1-510ec9f87c96 and Advisor created.
Updated Query to get from Advisor
aprlGuid: 72827434-c773-4345-9493-34848ddf5803 - Configure a snapshot for the Azure NetApp Files
Association between APRL and Advisor cda11061-35a8-4ca3-aa03-b242dcdf7319 created
Updated Query to get from Advisor
Microsoft.Network/loadBalancers
aprlGuid: 6d82d042-6d61-ad49-86f0-6a5455398081 - Ensure the Backend Pool contains at least two instances
Updated query and changed target ResourceType to Microsoft.Network/loadBalancers/backendAddressPools
aprlGuid: 6d82d042-6d61-ad49-86f0-6a5455398081 - Use Health Probes to detect backend instances availability
Recommendation removed. You can't create a load balancing rules without a health probe.
Microsoft.DBforPostgreSQL/flexibleServers
aprlGuid: 31f4ac4b-29cb-4588-8de2-d8fe6f13ceb3 - Configure geo redundant backup storage
Duplicated with Advisor. Updated query to get the data from Advisor.
Microsoft.Compute/VirtualMachines
aprlGuid: 52ab9e5c-eec0-3148-8bd7-b6dd9e1be870 - Use maintenance configurations for the VMs
Changed title to "Use maintenance configurations for the Dedicated and/or Isolated VM SKUs"
aprlGuid: 302fda08-ee65-4fbe-a916-6dc0b33169c4 - Reserve Compute Capacity for critical workloads
Updated Query to get from Advisor
Related Issues/Work Items
As part of this pull request I have
mainbranch