-
Notifications
You must be signed in to change notification settings - Fork 121
fix: Rosanto - Quality Updates - May/2025 #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4f39a34
rosanto-may-quality-updates
6b66e3f
commit1
00987d5
Update azure-resources/ContainerService/managedClusters/kql/e620fa98-…
rod-reis 946126c
Update azure-resources/Compute/virtualMachines/recommendations.yaml
rod-reis 1e4c196
Merge branch 'main' into rosanto-may-quality-updates
rod-reis 00d1676
updates
bec1eff
Merge branch 'rosanto-may-quality-updates' of https://github.com/Azur…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
18 changes: 12 additions & 6 deletions
18
azure-resources/Compute/virtualMachines/kql/302fda08-ee65-4fbe-a916-6dc0b33169c4.kql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,13 @@ | ||
| // Azure Resource Graph Query | ||
| // Find all Virtual Machines not associated with a Capacity Reservation, and provide details for Capacity Reservation like vmSize, location, and zone. | ||
| resources | ||
| | where type =~ 'Microsoft.Compute/virtualMachines' | ||
| | where isnull(properties.capacityReservation) | ||
| | extend zoneValue = iff(isnull(zones), "null", zones) | ||
| | project recommendationId = "302fda08-ee65-4fbe-a916-6dc0b33169c4", name, id, tags, param1 = strcat("VmSize: ", properties.hardwareProfile.vmSize), param2 = strcat("Location: ", location), param3 = strcat("Zone: ", zoneValue) | ||
| // Find Database for PostgreSQL instances that do not have geo redundant backup storage configured | ||
| advisorresources | ||
| | where properties.recommendationTypeId =~ '1670c0af-6536-4cbf-872f-152c91a51a80' // RecommendationID from Advisor | ||
| | mv-expand resId = properties.resourceMetadata.resourceId | ||
| | extend resId = tolower(tostring(resId)) | ||
| | project recId = properties.recommendationTypeId, resId | ||
| | join kind=leftouter ( | ||
| resources | ||
| | extend id = tolower(tostring(id)) | ||
| | project id, name, tags, location, properties | ||
| ) on $left.resId == $right.id | ||
| | project recommendationId = "302fda08-ee65-4fbe-a916-6dc0b33169c4", name , id = resId, tags,param1 = properties.hardwareProfile.vmSize, param2 = location | ||
42 changes: 32 additions & 10 deletions
42
azure-resources/Compute/virtualMachines/kql/52ab9e5c-eec0-3148-8bd7-b6dd9e1be870.kql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,38 @@ | ||
| // Azure Resource Graph Query | ||
| // Find VMS that do not have maintenance configuration assigned | ||
| Resources | ||
| | extend resourceId = tolower(id) | ||
| | project name, location, type, id, tags, resourceId, properties | ||
| // Find VMs on Dedicated Hosts or using Isolated SKUs (via substring match) that do NOT have a maintenance configuration assigned | ||
| resources | ||
| | where type =~ 'Microsoft.Compute/virtualMachines' | ||
| | extend | ||
| resourceId = tolower(id), | ||
| hostId = tostring(properties.host.id), | ||
| hostGroupId = tostring(properties.hostGroup.id), | ||
| vmSize = tostring(properties.hardwareProfile.vmSize) | ||
| | where | ||
| // 1) Dedicated Host association | ||
| isnotempty(hostId) or isnotempty(hostGroupId) | ||
| // 2) OR any of the "isolated" substrings | ||
| or ( | ||
| vmSize contains "i_" or | ||
| vmSize contains "is_" or | ||
| vmSize contains "id_" or | ||
| vmSize contains "ids_" or | ||
| vmSize contains "idms_" or | ||
| vmSize contains "ims_" or | ||
| vmSize contains "G5" or | ||
| vmSize contains "GS5" or | ||
| vmSize contains "F72s_" or | ||
| vmSize contains "M128ms" | ||
| ) | ||
| | join kind=leftouter ( | ||
| maintenanceresources | ||
| | where type =~ "microsoft.maintenance/configurationassignments" | ||
| | project planName = name, type, maintenanceProps = properties | ||
| | extend resourceId = tostring(maintenanceProps.resourceId) | ||
| resources | ||
| | where type =~ 'microsoft.maintenance/configurationassignments' | ||
| | extend resourceId = tolower(tostring(properties.resourceId)) | ||
| | project resourceId, maintenanceProps = properties | ||
| ) on resourceId | ||
| | where isnull(maintenanceProps) | ||
| | project recommendationId = "52ab9e5c-eec0-3148-8bd7-b6dd9e1be870",name, id, tags | ||
| | project | ||
| recommendationId = "52ab9e5c-eec0-3148-8bd7-b6dd9e1be870", | ||
| name, | ||
| id, | ||
| tags | ||
| | order by id asc | ||
|
|
18 changes: 17 additions & 1 deletion
18
azure-resources/Compute/virtualMachines/kql/73d1bb04-7d3e-0d47-bc0d-63afe773b5fe.kql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,18 @@ | ||
| // cannot-be-validated-with-arg | ||
| // Azure Resource Graph Query | ||
| // Find all VM NICs that have Accelerated Networking enabled | ||
| resources | ||
| | where type =~ 'Microsoft.Compute/virtualMachines' | ||
| | mv-expand nic = properties.networkProfile.networkInterfaces | ||
| | project name, id, tags, lowerCaseNicId = tolower(nic.id), vmSize = tostring(properties.hardwareProfile.vmSize) | ||
| | join kind = inner ( | ||
| resources | ||
| | where type =~ 'Microsoft.Network/networkInterfaces' | ||
| | where properties.enableAcceleratedNetworking == true | ||
| | project nicName = split(id, "/")[8], lowerCaseNicId = tolower(id) | ||
| ) | ||
| on lowerCaseNicId | ||
| | summarize nicNames = make_set(nicName) by name, id, tostring(tags), vmSize | ||
| | extend param2 = strcat("NicName: ", strcat_array(nicNames, ", ")), param3 = strcat("VMSize: ", vmSize) | ||
| | project recommendationId = "dfedbeb1-1519-fc47-86a5-52f96cf07105", name, id, tags, param1="This machine has AccelNet enabled, but it is not possible to confirm if the GuestOS drivers are Up-to-Date.", param2,param3 | ||
| | order by id asc | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.