Fix-ODAA_kql_folder_creation#742
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ODAA recommendations to include KQL folder creation for Oracle workloads, ensuring that both the recommendations and corresponding KQL query placeholder files are added or updated. Key changes include:
- Adding multiple KQL files with placeholder comments for query validation status.
- Updating recommendations YAML files for Cloud VM Clusters and Cloud Exadata Infrastructures with new guidance.
- Extending the APRL schema to include a new tag ("ORACLE") and refining field datatypes.
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| azure-specialized-workloads/oracle/kql/*.kql | Added new KQL files with placeholder comments indicating validation status or development state. |
| azure-resources/Oracledatabase/cloudexadatavmclusters/recommendations.yaml | Added recommendation details for Oracle Cloud VM Clusters with automation field. |
| azure-resources/Oracledatabase/cloudexadatainfrastructures/recommendations.yaml | Added recommendation details for Oracle Cloud Exadata Infrastructures with automation field. |
| .github/scripts/schemas/aprl-schema.yaml | Updated schema to extend tag enum with "ORACLE". |
| Other index markdown files | Updated documentation indices to support the new recommendation categories. |
| @@ -0,0 +1 @@ | |||
| // cannot-be-validated-with-arg | |||
There was a problem hiding this comment.
[nitpick] Consider standardizing the placeholder comments across all KQL files. For example, use a consistent marker (either 'cannot-be-validated-with-arg' or 'under-development') to clearly communicate the file status.
| // cannot-be-validated-with-arg | |
| // under-development |
| pgVerified: false | ||
| publishedToLearn: false | ||
| publishedToAdvisor: false | ||
| automationAvailable: arg |
There was a problem hiding this comment.
The automationAvailable field is set to 'arg', but the APRL schema expects a boolean value. Consider updating this field to a boolean to ensure consistency with the schema.
| automationAvailable: arg | |
| automationAvailable: false |
| pgVerified: false | ||
| publishedToLearn: false | ||
| publishedToAdvisor: false | ||
| automationAvailable: arg |
There was a problem hiding this comment.
The automationAvailable field is set to 'arg', yet the schema defines this as a boolean. Align the value with the schema requirements by updating it to a boolean.
| automationAvailable: arg | |
| automationAvailable: true |
Overview/Summary
Update to the existing ODAA recommendation and adding KQL folder creation
Related Issues/Work Items
adding KQL folder creation for Exa Infra and VM cluster KQLs
AB#succeeded with the ADO Work Item ID.Examples:
Fixes AB#123
-->
Breaking Changes
As part of this pull request I have
mainbranch