Skip to content

fix: Added advisor ID's for PostgreSQL, Firewall and Load Balancer Zone re…#743

Merged
kpoineal merged 1 commit into
Azure:mainfrom
edknox:azoresadvisorids
May 23, 2025
Merged

fix: Added advisor ID's for PostgreSQL, Firewall and Load Balancer Zone re…#743
kpoineal merged 1 commit into
Azure:mainfrom
edknox:azoresadvisorids

Conversation

@edknox
Copy link
Copy Markdown
Contributor

@edknox edknox commented May 22, 2025

Overview/Summary

Added advisor ID's for PostgreSQL, Firewall and Load Balancer Zone recommendations

AB#40842

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Copilot AI review requested due to automatic review settings May 22, 2025 13:07
@edknox edknox requested review from a team as code owners May 22, 2025 13:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds advisor IDs for recommendations in PostgreSQL, Firewall, and Load Balancer Zone configurations to ensure that each recommendation is associated with a specific advisor ID.

  • Updated the Load Balancer recommendations with a new advisor ID.
  • Updated the Azure Firewall recommendations with a new advisor ID.
  • Updated the PostgreSQL Flexible Server recommendations with a new advisor ID.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
azure-resources/Network/loadBalancers/recommendations.yaml Updated advisor ID for zone-redundancy recommendation.
azure-resources/Network/azureFirewalls/recommendations.yaml Updated advisor ID for multi-zone Azure Firewall deployment recommendation.
azure-resources/DBforPostgreSQL/flexibleServers/recommendations.yaml Updated advisor ID for PostgreSQL HA with zone redundancy.

Copy link
Copy Markdown
Contributor

@ehaslett ehaslett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpoineal kpoineal changed the title Added advisor ID's for PostgreSQL, Firewall and Load Balancer Zone re… Fix: Added advisor ID's for PostgreSQL, Firewall and Load Balancer Zone re… May 23, 2025
@kpoineal kpoineal changed the title Fix: Added advisor ID's for PostgreSQL, Firewall and Load Balancer Zone re… fix: Added advisor ID's for PostgreSQL, Firewall and Load Balancer Zone re… May 23, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Bug 🐞 Something isn't working label May 23, 2025
@kpoineal kpoineal merged commit 77c8a84 into Azure:main May 23, 2025
9 of 13 checks passed
@edknox edknox deleted the azoresadvisorids branch May 23, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug 🐞 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants