Skip to content

fix: This PR resolves issues with AKS, Netapp, VMSS and Traffic Analytics ARGs#744

Closed
rod-reis wants to merge 8 commits into
mainfrom
rosanto-may-quality-updates
Closed

fix: This PR resolves issues with AKS, Netapp, VMSS and Traffic Analytics ARGs#744
rod-reis wants to merge 8 commits into
mainfrom
rosanto-may-quality-updates

Conversation

@rod-reis

Copy link
Copy Markdown
Contributor

Overview/Summary

Fix: This PR resolves issues with AKS, Netapp, VMSS and Traffic Analytics ARGs

Related Issues/Work Items

There were some queries projecting ResourceTypes not available via ARG. In other cases, creaing duplicated entries.

As part of this pull request I have

  • [ x] Read the Contribution Guide and ensured this PR is compliant with the guide
  • [ x] Checked for duplicate Pull Requests
  • [ x] Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • [ x] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [ x] Ensured PR tests are passing
  • [ x] Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • [ x] Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Copilot AI review requested due to automatic review settings May 23, 2025 21:18
@rod-reis rod-reis requested review from a team as code owners May 23, 2025 21:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses several issues with Azure Resource Graph recommendations for AKS, Netapp, VMSS, and Traffic Analytics by updating recommendation IDs, modifying query filters, and refining metadata settings. Key changes include:

  • Updating recommendationTypeId and metadata settings for PostgreSQL and AKS resources.
  • Refining KQL queries for managed clusters and virtual machines to improve resource filtering and tagging.
  • Adding a new recommendation for using Ephemeral OS Disks with VMSS node pools.

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
azure-resources/DBforPostgreSQL/flexibleServers/recommendations.yaml Updated recommendationTypeId for geo redundant backup storage.
azure-resources/DBforPostgreSQL/flexibleServers/kql/31f4ac4b-29cb-4588-8de2-d8fe6f13ceb3.kql Updated query to use the new recommendation ID.
azure-resources/ContainerService/managedClusters/recommendations.yaml Modified recommendationMetadataState and removed an obsolete recommendation block.
Various azure-resources/ContainerService/managedClusters/kql/*.kql Adjusted queries to incorporate case-insensitive comparisons, enhanced joins, and added tagging.
azure-resources/Compute/virtualMachines/recommendations.yaml Changed automationAvailable setting and adjusted several recommendation definitions.
azure-resources/Compute/virtualMachineScaleSets/recommendations.yaml & kql/a7bfcc18-b0d8-4d37-81f3-8131ed8bead5.kql Added new recommendation and corresponding query for Ephemeral OS Disks on VMSS node pools.
Comments suppressed due to low confidence (4)

azure-resources/ContainerService/managedClusters/kql/a7bfcc18-b0d8-4d37-81f3-8131ed8bead5.kql:1

  • Since this query file has been removed, confirm that no other parts of the codebase rely on it before final deletion.
// Azure Resource Graph Query (file removal)

azure-resources/ContainerService/managedClusters/kql/4f63619f-5001-439c-bacb-8de891287727.kql:13

  • Ensure that constructing the node pool identifier using pool.name with strcat is consistent with resource identification used in other queries.
name=pool.name,

azure-resources/Compute/virtualMachines/recommendations.yaml:148

  • Verify that enabling automationAvailable for Accelerated Networking is intentional, as the previous setting was false, which might impact automation processes.
automationAvailable: true

azure-resources/Compute/virtualMachineScaleSets/recommendations.yaml:155

  • Ensure that reusing the aprlGuid 'a7bfcc18-b0d8-4d37-81f3-8131ed8bead5' for the new VMSS recommendation is intentional and does not conflict with previous usage in deleted or existing queries.
aprlGuid: a7bfcc18-b0d8-4d37-81f3-8131ed8bead5

@kpoineal kpoineal changed the title Fix: This PR resolves issues with AKS, Netapp, VMSS and Traffic Analytics ARGs fix: This PR resolves issues with AKS, Netapp, VMSS and Traffic Analytics ARGs May 23, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Bug 🐞 Something isn't working label May 23, 2025
@rod-reis rod-reis closed this May 23, 2025
@rod-reis rod-reis deleted the rosanto-may-quality-updates branch May 23, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug 🐞 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants