fix: This PR resolves issues with AKS, Netapp, VMSS and Traffic Analytics ARGs#744
Closed
rod-reis wants to merge 8 commits into
Closed
fix: This PR resolves issues with AKS, Netapp, VMSS and Traffic Analytics ARGs#744rod-reis wants to merge 8 commits into
rod-reis wants to merge 8 commits into
Conversation
…7a40-41a0-bfc9-b4407297fb58.kql Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…e/Azure-Proactive-Resiliency-Library-v2 into rosanto-may-quality-updates
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses several issues with Azure Resource Graph recommendations for AKS, Netapp, VMSS, and Traffic Analytics by updating recommendation IDs, modifying query filters, and refining metadata settings. Key changes include:
- Updating recommendationTypeId and metadata settings for PostgreSQL and AKS resources.
- Refining KQL queries for managed clusters and virtual machines to improve resource filtering and tagging.
- Adding a new recommendation for using Ephemeral OS Disks with VMSS node pools.
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| azure-resources/DBforPostgreSQL/flexibleServers/recommendations.yaml | Updated recommendationTypeId for geo redundant backup storage. |
| azure-resources/DBforPostgreSQL/flexibleServers/kql/31f4ac4b-29cb-4588-8de2-d8fe6f13ceb3.kql | Updated query to use the new recommendation ID. |
| azure-resources/ContainerService/managedClusters/recommendations.yaml | Modified recommendationMetadataState and removed an obsolete recommendation block. |
| Various azure-resources/ContainerService/managedClusters/kql/*.kql | Adjusted queries to incorporate case-insensitive comparisons, enhanced joins, and added tagging. |
| azure-resources/Compute/virtualMachines/recommendations.yaml | Changed automationAvailable setting and adjusted several recommendation definitions. |
| azure-resources/Compute/virtualMachineScaleSets/recommendations.yaml & kql/a7bfcc18-b0d8-4d37-81f3-8131ed8bead5.kql | Added new recommendation and corresponding query for Ephemeral OS Disks on VMSS node pools. |
Comments suppressed due to low confidence (4)
azure-resources/ContainerService/managedClusters/kql/a7bfcc18-b0d8-4d37-81f3-8131ed8bead5.kql:1
- Since this query file has been removed, confirm that no other parts of the codebase rely on it before final deletion.
// Azure Resource Graph Query (file removal)
azure-resources/ContainerService/managedClusters/kql/4f63619f-5001-439c-bacb-8de891287727.kql:13
- Ensure that constructing the node pool identifier using pool.name with strcat is consistent with resource identification used in other queries.
name=pool.name,
azure-resources/Compute/virtualMachines/recommendations.yaml:148
- Verify that enabling automationAvailable for Accelerated Networking is intentional, as the previous setting was false, which might impact automation processes.
automationAvailable: true
azure-resources/Compute/virtualMachineScaleSets/recommendations.yaml:155
- Ensure that reusing the aprlGuid 'a7bfcc18-b0d8-4d37-81f3-8131ed8bead5' for the new VMSS recommendation is intentional and does not conflict with previous usage in deleted or existing queries.
aprlGuid: a7bfcc18-b0d8-4d37-81f3-8131ed8bead5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Fix: This PR resolves issues with AKS, Netapp, VMSS and Traffic Analytics ARGs
Related Issues/Work Items
There were some queries projecting ResourceTypes not available via ARG. In other cases, creaing duplicated entries.
As part of this pull request I have
mainbranch