fix: This PR resolves issues with AKS, VMSS and Load Balancers ARGs

[rod-reis]

Overview/Summary

fix: This PR resolves issues with AKS, VMSS and Load Balancers ARGs

Related Issues/Work Items

Breaking Changes

As part of this pull request I have

• [ x] Read the Contribution Guide and ensured this PR is compliant with the guide
• [ x] Checked for duplicate Pull Requests
• [ x] Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
• [ x] Ensured my code/branch is up-to-date with the latest changes in the main branch
• [ x] Ensured PR tests are passing
• [ x] Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
• [ x] Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

[Copilot]

Pull Request Overview

This PR fixes issues with ARGs for AKS, VMSS, and Load Balancers by updating resource types and query logic for improved accuracy and consistency.

• Updated resource types in recommendations YAML files for load balancers and managed clusters.
• Modified and added KQL queries to align with the new resource definitions.
• Introduced a new recommendation and query for ephemeral OS disks on AKS VMSS node pools.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
azure-resources/Network/loadBalancers/recommendations.yaml	Changed recommendationResourceType to target the load balancer rather than its backend pools.
azure-resources/Network/loadBalancers/kql/6d82d042-6d61-ad49-86f0-6a5455398081.kql	Updated query comments and structure to reflect updated resource type.
azure-resources/ContainerService/managedClusters/recommendations.yaml	Updated recommendationResourceType from agentPools to managedClusters and removed the deprecated ephemeral OS disk recommendation.
azure-resources/ContainerService/managedClusters/kql/f46b0d1d-56ef-4795-b98a-f6ee00cb341a.kql	Revised query to summarize cluster node pool details based on the updated resource type.
azure-resources/ContainerService/managedClusters/kql/a7bfcc18-b0d8-4d37-81f3-8131ed8bead5.kql	Removed the ephemeral disk query block.
azure-resources/ContainerService/managedClusters/kql/005ccbbd-aeab-46ef-80bd-9bd4479412ec.kql	Adjusted query projection to use the updated naming convention.
azure-resources/Compute/virtualMachineScaleSets/recommendations.yaml	Added a new recommendation for using Ephemeral OS Disks on AKS VMSS Node Pools.
azure-resources/Compute/virtualMachineScaleSets/kql/a7bfcc18-b0d8-4d37-81f3-8131ed8bead5.kql	Introduced a new query joining managed clusters with VMSS to detect non-Ephemeral OS disk usage.

Comments suppressed due to low confidence (3)

azure-resources/Compute/virtualMachineScaleSets/kql/a7bfcc18-b0d8-4d37-81f3-8131ed8bead5.kql:28

• [nitpick] Ensure that using tolower for both resourceGroup fields in the join condition does not negatively impact performance on larger datasets; if possible, consider normalizing values upstream.

and tolower(resourceGroup) == tolower(nodeResourceGroup)

azure-resources/Network/loadBalancers/recommendations.yaml:23

• Ensure that changing the recommendation resource type from 'Microsoft.Network/loadBalancers/backendAddressPools' to 'Microsoft.Network/loadBalancers' is intentional and that any dependent processes or queries are updated accordingly.

recommendationResourceType: Microsoft.Network/loadBalancers

azure-resources/ContainerService/managedClusters/recommendations.yaml:6

• Confirm that updating the recommendation resource type from '.../agentPools' to '.../managedClusters' is deliberate, and verify that associated queries now correctly target the modified resource.

recommendationResourceType: Microsoft.ContainerService/managedClusters

[tksh164]

Added comments.

[rod-reis]

Agree, I'm removing the line and submitting a new commit with all changes. I only reject the change of the osDiskType string change, let's keep it simple, this is all going to Advisor which does not project Params.