Skip to content

fix: adding_Oracle_kql_queries#746

Merged
tksh164 merged 14 commits into
Azure:mainfrom
gkayali:main
Jun 11, 2025
Merged

fix: adding_Oracle_kql_queries#746
tksh164 merged 14 commits into
Azure:mainfrom
gkayali:main

Conversation

@gkayali
Copy link
Copy Markdown
Contributor

@gkayali gkayali commented May 27, 2025

Adding the missing Oracle kql queries directory

Related Issues/Work Items

The PR fixes the top URLs in the ODAA WARA page

Breaking Changes

  1. Replace me
  2. Replace me

As part of this pull request I have

  • [ x] Read the Contribution Guide and ensured this PR is compliant with the guide
  • [x ] Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • [x ] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Copilot AI review requested due to automatic review settings May 27, 2025 15:39
@gkayali gkayali requested a review from a team as a code owner May 27, 2025 15:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds the missing Oracle recommendations and KQL query stubs for Exadata VM clusters and infrastructures, along with their documentation index pages.

  • Introduces recommendations.yaml entries for ODAA Exadata VM clusters and infrastructures.
  • Adds placeholder KQL query files marked as “under-development.”
  • Creates index.md pages for each resource folder and the root Oracle Database section.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
azure-resources/Oracledatabase/cloudexadatavmclusters/recommendations.yaml Added recommendation metadata for VM clusters
azure-resources/Oracledatabase/cloudexadatavmclusters/kql/4b33324a-70cd-4bac-bdae-da4c382c436b.kql Added placeholder KQL query stub
azure-resources/Oracledatabase/cloudexadatavmclusters/_index.md Created resource index page for VM clusters
azure-resources/Oracledatabase/cloudexadatainfrastructures/recommendations.yaml Added recommendation metadata for infrastructures
azure-resources/Oracledatabase/cloudexadatainfrastructures/kql/c99d730b-8754-447f-bd5d-3e8850a12235.kql Added placeholder KQL query stub
azure-resources/Oracledatabase/cloudexadatainfrastructures/_index.md Created resource index page for infrastructures
azure-resources/Oracledatabase/_index.md Created root index page for Oracle Database section
Comments suppressed due to low confidence (2)

azure-resources/Oracledatabase/cloudexadatavmclusters/_index.md:2

  • [nitpick] The title uses lowercase and lacks clear word boundaries. Consider renaming to "CloudExadataVMClusters" to match PascalCase conventions used elsewhere.
title: "Cloudvmclusters"

azure-resources/Oracledatabase/cloudexadatainfrastructures/_index.md:2

  • [nitpick] The title should follow PascalCase for consistency; consider "CloudExadataInfrastructures".
title: "Cloudexadatainfrastructures"

@gkayali gkayali changed the title adding_Oracle_kql_queries Fix- adding_Oracle_kql_queries May 27, 2025
@kpoineal kpoineal changed the title Fix- adding_Oracle_kql_queries fix: adding_Oracle_kql_queries May 27, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Bug 🐞 Something isn't working label May 27, 2025
@Azure Azure deleted a comment from Copilot AI May 27, 2025
@Azure Azure deleted a comment from Copilot AI May 27, 2025
Comment thread .editorconfig
@kpoineal
Copy link
Copy Markdown
Contributor

kpoineal commented Jun 3, 2025

@gkayali Can you please change all of the other ODAA recommendations to use false for automationAvailable ?

They currently have "no" :P

@gkayali
Copy link
Copy Markdown
Contributor Author

gkayali commented Jun 3, 2025

@gkayali Can you please change all of the other ODAA recommendations to use false for automationAvailable ?

They currently have "no" :P

@kpoineal Is this case for the queries in-progress the ones targeting the two resources on the top section ?

@kpoineal kpoineal requested a review from tksh164 June 10, 2025 21:37
@tksh164 tksh164 merged commit bdbf44c into Azure:main Jun 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug 🐞 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants