Skip to content

fix: Fix to manual scaling setting handling in 005ccbbd-aeab-46ef-80bd-9bd4479412ec#750

Merged
tksh164 merged 6 commits into
mainfrom
fix/issue749
Sep 9, 2025
Merged

fix: Fix to manual scaling setting handling in 005ccbbd-aeab-46ef-80bd-9bd4479412ec#750
tksh164 merged 6 commits into
mainfrom
fix/issue749

Conversation

@tksh164
Copy link
Copy Markdown
Member

@tksh164 tksh164 commented May 30, 2025

Overview/Summary

Fixes to the manual scaling setting handling in 005ccbbd-aeab-46ef-80bd-9bd4479412ec.

Related Issues/Work Items

Breaking Changes

  • None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Screenshots

image

Copilot AI review requested due to automatic review settings May 30, 2025 17:04
@tksh164 tksh164 requested a review from a team as a code owner May 30, 2025 17:04
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Bug 🐞 Something isn't working label May 30, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the AKS node pool query to correctly handle manual vs. auto-scaling scenarios and makes the type filter case-insensitive.

  • Changes the resource type match to use case-insensitive operator (=~).
  • Splits taint and scaling filters, adding separate logic for enableAutoScaling true/false.
  • Updates projection to include the enableAutoScaling flag and conditionally show minCount or count.
Comments suppressed due to low confidence (1)

azure-resources/ContainerService/managedClusters/kql/005ccbbd-aeab-46ef-80bd-9bd4479412ec.kql:10

  • Add or update unit/integration tests to cover both enableAutoScaling = true and enableAutoScaling = false paths to ensure the query filters correctly in each scenario.
| where (agentPoolProfile.enableAutoScaling == true and agentPoolProfile["minCount"] < 2) or (agentPoolProfile.enableAutoScaling == false and agentPoolProfile["count"] < 2)

@tksh164 tksh164 enabled auto-merge (squash) June 5, 2025 00:05
@tksh164 tksh164 merged commit 6c15d5c into main Sep 9, 2025
10 checks passed
@tksh164 tksh164 deleted the fix/issue749 branch September 9, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug 🐞 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants