Skip to content

fix: AdvisorRecId for AppService rec#790

Merged
arthurclares merged 2 commits into
mainfrom
arthurclares-patch-1
Nov 12, 2025
Merged

fix: AdvisorRecId for AppService rec#790
arthurclares merged 2 commits into
mainfrom
arthurclares-patch-1

Conversation

@arthurclares
Copy link
Copy Markdown
Collaborator

Include Advisor ID for APRL recID 855ca19a-6518-4f2e-9e5a-01796fbca9f8

Overview/Summary

Related Issues/Work Items

Breaking Changes

  1. Replace me
  2. Replace me

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Include Advisor ID for APRL recID  855ca19a-6518-4f2e-9e5a-01796fbca9f8
@arthurclares arthurclares requested a review from a team as a code owner November 12, 2025 13:03
Copilot AI review requested due to automatic review settings November 12, 2025 13:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the Azure Advisor recommendation ID for the App Service recommendation to set minimum instance count to 2. The change updates the recommendationTypeId field from null to a valid GUID that links to the corresponding Azure Advisor recommendation.

  • Updated recommendationTypeId from null to e987dcce-fd2c-4683-8abf-f1a34bbad737 for the minimum instance count recommendation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread azure-resources/Web/serverFarms/recommendations.yaml Outdated
Copy link
Copy Markdown
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update to fix the failing PR tests?

@arthurclares arthurclares changed the title Add AdvisorRecId for AppService rec fix: AdvisorRecId for AppService rec Nov 12, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Bug 🐞 Something isn't working label Nov 12, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@arthurclares arthurclares enabled auto-merge (squash) November 12, 2025 16:11
@arthurclares arthurclares merged commit aef06e9 into main Nov 12, 2025
11 of 12 checks passed
@arthurclares arthurclares deleted the arthurclares-patch-1 branch November 12, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug 🐞 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants