Commit 190ed71
committed
fix(tailscale): remove empty groupByEntities from all 24 analytic rules
Resolves the ARM-TTK "Template Should Not Contain Blanks" failure
v-shukore flagged locally with test-AzTemplate (20+ "Empty property: []"
errors at Column 39, same failure class as the ApiKeyIdentifier: "" bug
on the UniFi PR).
Root cause: every rule's incidentConfiguration.groupingConfiguration
block had a literal `groupByEntities: []` line. groupByEntities is only
meaningful when matchingMethod is "Selected" (grouping incidents by
specific entity types); all 24 Tailscale rules use
`matchingMethod: AllEntities`, making the empty array pure inert
boilerplate. Empty arrays aren't in ARM-TTK's default allow-list
(unlike e.g. `defaultValue`, `properties`, `resources`), so the packaged
mainTemplate.json failed on 24 instances - one per rule, at the exact
line numbers in the reviewer's screenshot (4632, 4754, ... 7464).
Why our own CI runs didn't catch this: .script/local-validation/
run-arm-ttk.ps1 explicitly skips "Template Should Not Contain Blanks"
(mirroring .github/actions/entrypoint.ps1's filter list, which the real
upstream GitHub Actions run-arm-ttk check also applies) - so neither our
local wrapper nor the official CI check ever exercised this test. The
reviewer caught it by running Test-AzTemplate directly, without those
filters. Confirmed via the same raw invocation locally: before this
fix, "Template Should Not Contain Blanks" failed with exactly 24 errors;
after, 0.
Also ran the FULL unfiltered ARM-TTK suite (50 tests, no skip list at
all) to make sure nothing else was hiding behind our wrapper's filters.
Only remaining failure: "IDs Should Be Derived From ResourceIDs" - the
known, unavoidable false positive on CCF multi-poller solutions (Mustache
{{...}} placeholders in dataCollectionEndpointId/auth.AppId), already
documented from the UniFi PR and filtered by both our wrapper and the
real upstream CI. Not a regression, not actionable.
Files: groupByEntities: [] line removed from all 24
Analytic Rules/*.yaml. Package/ regenerated and repinned to 3.0.0.1 parent 2d8c075 commit 190ed71
26 files changed
Lines changed: 182 additions & 230 deletions
File tree
- Solutions/Tailscale (CCF)
- Analytic Rules
- Package
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | 40 | | |
42 | 41 | | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | 52 | | |
54 | 53 | | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
45 | 44 | | |
46 | 45 | | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
54 | 53 | | |
55 | 54 | | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
45 | 44 | | |
46 | 45 | | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
44 | 43 | | |
45 | 44 | | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | 51 | | |
53 | 52 | | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | 41 | | |
43 | 42 | | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
47 | 46 | | |
48 | 47 | | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | 41 | | |
43 | 42 | | |
0 commit comments