Skip to content

Commit fba169d

Browse files
committed
Merge branch 'master' into dependabot/pip/Solutions/Cloudflare/Data-Connectors/aiohttp-3.13.4
2 parents 2952add + fe85011 commit fba169d

112 files changed

Lines changed: 10687 additions & 1767 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/instructions/detections.instructions.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,26 @@ Analytic Rules are YAML files that define scheduled queries to detect threats, s
317317
- Must include all connectors required for query execution
318318
- Specify exact data types needed
319319
- Use official connector IDs
320+
321+
#### **connectorId Validation**
322+
- **Source of Truth**: All `connectorId` values must be validated against the official list:
323+
```
324+
https://github.com/Azure/Azure-Sentinel/blob/master/.script/tests/detectionTemplateSchemaValidation/ValidConnectorIds.json
325+
```
326+
- **Validation Process**:
327+
- Check if the `connectorId` value exists in ValidConnectorIds.json
328+
- If NOT found: Flag as invalid and request update to ValidConnectorIds.json
329+
- Case-sensitive matching required
330+
- **Valid Examples**:
331+
- `CiscoDuoSecurity` ✅ (exists in valid list)
332+
- `AzureActiveDirectory` ✅ (exists in valid list)
333+
- `CiscoASA` ✅ (exists in valid list)
334+
- **Invalid Examples**:
335+
- `CiscoDuo` ❌ (correct ID is `CiscoDuoSecurity`)
336+
- `AzureAD` ❌ (correct ID is `AzureActiveDirectory`)
337+
- `CustomConnectorXYZ` ❌ (not in official list - needs to be added to ValidConnectorIds.json)
338+
- **Action if Invalid**:
339+
- Comment: "connectorId `[value]` is not found in the ValidConnectorIds.json file. Please update ValidConnectorIds.json to include this connector or use a valid connector ID from the official list."
320340
321341
#### **entityMappings** (Entity Extraction)
322342
- **Required**: Yes for Detections

0 commit comments

Comments
 (0)