Skip to content

Add Valimail Enforce Configuration Events CCF Connector#14045

Merged
v-dvedak merged 7 commits intoAzure:masterfrom
ValiMail:valimail-enforce-config-events
Apr 24, 2026
Merged

Add Valimail Enforce Configuration Events CCF Connector#14045
v-dvedak merged 7 commits intoAzure:masterfrom
ValiMail:valimail-enforce-config-events

Conversation

@gborbollal
Copy link
Copy Markdown
Contributor

@gborbollal gborbollal commented Apr 10, 2026

Required items, please complete

Change(s):

  • New CCF Connector to pull the Configuration Events in the Valimail Enforce Platform

Reason for Change(s):

  • Initial implementation

Version Updated:

  • First release: 3.0.0

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • The package generation script showed no errors.

@gborbollal gborbollal requested review from a team as code owners April 10, 2026 21:04
@gborbollal
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="Valimail"

@v-shukore v-shukore self-assigned this Apr 13, 2026
@v-shukore v-shukore added the New Solution For new Solutions which are new to Microsoft Sentinel label Apr 13, 2026
@gborbollal gborbollal force-pushed the valimail-enforce-config-events branch 4 times, most recently from 18dcbd7 to 3f1a9a2 Compare April 13, 2026 21:24
Copy link
Copy Markdown
Contributor Author

@gborbollal gborbollal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ValidConnectorsId.json merged.
Thank you.

@v-shukore v-shukore requested a review from Copilot April 17, 2026 06:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds the initial Valimail Enforce solution content, centered around a new Codeless Connector Framework (CCF) connector for configuration events, plus accompanying analytics and hunting content and validation updates.

Changes:

  • Added Valimail Enforce solution metadata + solution data manifest.
  • Added 4 analytic rules and 4 hunting queries for Valimail Enforce events.
  • Updated repo validation assets (ValidConnectorIds + custom table schema) to support the new connector/table.

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
Solutions/ValimailEnforce/SolutionMetadata.json Introduces solution marketplace metadata (publisher/offer/support/categorization).
Solutions/ValimailEnforce/Package/testParameters.json ARM test parameters for packaged deployment (ignored for review per repo rules).
Solutions/ValimailEnforce/Package/mainTemplate.json Packaged ARM template for solution deployment (ignored for review per repo rules).
Solutions/ValimailEnforce/Package/createUiDefinition.json Portal createUiDefinition for the solution (ignored for review per repo rules).
Solutions/ValimailEnforce/Hunting Queries/ValimailEnforce_HighValueEventSummary.yaml Adds a hunting query to summarize high-value events for analyst review.
Solutions/ValimailEnforce/Hunting Queries/ValimailEnforce_DMARCPolicyHistory.yaml Adds a hunting query to inspect DMARC policy change history.
Solutions/ValimailEnforce/Hunting Queries/ValimailEnforce_ChangeRateTrend.yaml Adds a hunting query to trend config change rates by user/domain.
Solutions/ValimailEnforce/Hunting Queries/ValimailEnforce_BulkChanges.yaml Adds a hunting query to detect bulk domain changes by a single user.
Solutions/ValimailEnforce/Data/Solution_ValimailEvents.json Defines the solution package contents (connectors/rules/queries) and metadata used by packaging.
Solutions/ValimailEnforce/Data Connectors/ValimailEnforceEventLogs_ccp/ValimailEnforceEventLogs_connectorDefinition.json CCF connector definition for Valimail Enforce events (ignored for review per repo rules).
Solutions/ValimailEnforce/Data Connectors/ValimailEnforceEventLogs_ccp/ValimailEnforceEventLogs_Table.json Custom table schema for Valimail Enforce events (ignored for review per repo rules).
Solutions/ValimailEnforce/Data Connectors/ValimailEnforceEventLogs_ccp/ValimailEnforceEventLogs_PollerConfig.json REST poller configuration for the connector (ignored for review per repo rules).
Solutions/ValimailEnforce/Data Connectors/ValimailEnforceEventLogs_ccp/ValimailEnforceEventLogs_DCR.json Data Collection Rule definition for transforming/ingesting events (ignored for review per repo rules).
Solutions/ValimailEnforce/Analytic Rules/ValimailEnforce_UserManagementHighValue.yaml Adds a scheduled analytic rule for high-value user management events.
Solutions/ValimailEnforce/Analytic Rules/ValimailEnforce_UnusualChangeRate.yaml Adds a scheduled analytic rule for anomalous configuration change bursts.
Solutions/ValimailEnforce/Analytic Rules/ValimailEnforce_DMARCPolicyWeakened.yaml Adds a scheduled analytic rule for DMARC policy weakened to none.
Solutions/ValimailEnforce/Analytic Rules/ValimailEnforce_AuthKeyChanged.yaml Adds a scheduled analytic rule for deleted SPF/DKIM auth keys.
.script/tests/detectionTemplateSchemaValidation/ValidConnectorIds.json Allows ValimailEnforce as a valid connectorId for detections/hunts.
.script/tests/KqlvalidationsTests/CustomTables/ValimailEnforceEvents_CL.json Adds KQL validation schema for the custom table used by rules/queries.
Comments suppressed due to low confidence (1)

Solutions/ValimailEnforce/SolutionMetadata.json:1

  • offerId does not meet Partner-tier requirements (it must contain the keyword "sentinel"), and publisherId/support email appear to have a "valmail"/"valimail" inconsistency that will likely fail validation and/or provide the wrong support contact. Update offerId to include "sentinel" (and stay <= 50 chars), and align publisherId + support email domain to the correct/approved values (custom publisherId also needs to be pre-approved per solution-metadata validation rules).
{

Comment thread Solutions/ValimailEnforce/Data/Solution_ValimailEvents.json Outdated
Comment on lines +23 to +27
"BasePath": "..\\..\\..\\\\Azure-Sentinel\\Solutions\\ValimailEnforce",
"Version": "1.0.1",
"Metadata": "SolutionMetadata.json",
"TemplateSpec": true,
"Is1PConnector": false
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Solution data file doesn’t match required solution-data conventions: (1) Logo should reference a repo-hosted asset via a raw.githubusercontent.com/Azure/Azure-Sentinel/master/Logos/... URL and use the standard 75px x 75px dimensions (external vendor URL + 100px sizing will fail validation), (2) Author for a Partner solution should use the partner org/support email format rather than Microsoft support, (3) Description is missing the expected “Underlying Microsoft Technologies used” section and dependency/cost/preview notes, and (4) BasePath is machine/repo-layout specific (backslash-heavy) and is likely to break in CI—use a stable repo-relative path format instead.

Copilot uses AI. Check for mistakes.
Comment on lines +24 to +26
"Version": "1.0.1",
"Metadata": "SolutionMetadata.json",
"TemplateSpec": true,
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description states “First release: 3.0.0”, but this solution manifest sets Version to 1.0.1. Please align the solution versioning across the PR (and note: if you update this manifest to 3.x.x, solution-data validation rules require TemplateSpec to be false for 3.. versions).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gborbollal, please make sure version should be 3.0.0 and TemplateSpec to be false update it and commit the changes. Thanks!

Comment thread Solutions/ValimailEnforce/Analytic Rules/ValimailEnforce_AuthKeyChanged.yaml Outdated
Comment thread Solutions/ValimailEnforce/Analytic Rules/ValimailEnforce_DMARCPolicyWeakened.yaml Outdated
Comment thread Solutions/ValimailEnforce/Hunting Queries/ValimailEnforce_ChangeRateTrend.yaml Outdated
Removing - we will create a name without spaces

Valimail Enforce configuration - Poller completion pending

Connector definition complete

Solution files completed

Use workspace-location instead of location; logo backgorund.

Fix deployment parameters

Fixes to parameters and names

Fix json path and endpoint for staging.

Analytic Rules, Hunting queries and transformation rules.

Analytic Rules, Hunting queries and transformation rules.

Solition Package

Revert accidental changes in SentinelOne

Remove generated Sentinel One package

Remove shell to package the solution

ValimailEnforceEvents_CL custom table in the .scripts directory
…meters

Restore CR line endings.

Generate package

Remove packaging script

Fix ValidConnectorIds diff

Update ValidConnectorIds.json
@gborbollal gborbollal force-pushed the valimail-enforce-config-events branch from 69a90a4 to 01bad05 Compare April 17, 2026 22:53
@v-shukore
Copy link
Copy Markdown
Contributor

Hi @gborbollal, thank you for making the updates suggested by the copilot. I’ll review the PR and let you know here if anything else is needed. Thanks!

@v-shukore
Copy link
Copy Markdown
Contributor

Hi @gborbollal, please make sure version should be 3.0.0 and TemplateSpec to be false update it and commit the changes. Also, add releasenotes.md file for this solution. Thanks!

@gborbollal
Copy link
Copy Markdown
Contributor Author

Thank You @v-shukore ! On it.

Comment thread Solutions/ValimailEnforce/Data/Solution_ValimailEvents.json
Comment thread Solutions/ValimailEnforce/Data/Solution_ValimailEvents.json
Comment thread Solutions/ValimailEnforce/ReleaseNotes.md
@gborbollal gborbollal requested a review from v-shukore April 22, 2026 21:17
@v-dvedak v-dvedak merged commit 4004c09 into Azure:master Apr 24, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Solution For new Solutions which are new to Microsoft Sentinel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants