push ZoomReports To GA#14146
Conversation
|
@microsoft-github-policy-service agree company="Microsoft" |
| EventOriginalTime=column_ifexists('Time', ''), | ||
| EventOriginalMessage=column_ifexists('OperationDetail', ''), | ||
| EventResult=column_ifexists('ActivityType', ''), | ||
| UserType=column_ifexists('ActivityType', ''), |
There was a problem hiding this comment.
Should this be checking if UserType exists?
There was a problem hiding this comment.
They share the same data source, just an additional column whose name is derived from the api response schema, however, since the EventResult and UserType in the original parser already covered the use case of the data source, to simplifying the parser, I've removed ActivityType from the parser, we will just reuse existing ones to simplify it and introduce no breaking changes.
| Date=column_ifexists('ReportDate', ''), | ||
| EventDay=column_ifexists('ReportDate', ''), | ||
| NewUsersCount=tostring(column_ifexists('NewUsers', '')), | ||
| MeetingsCount=tostring(column_ifexists('Meetings', '')), |
| | extend | ||
| Date=column_ifexists('ReportDate', ''), | ||
| EventDay=column_ifexists('ReportDate', ''), | ||
| NewUsersCount=tostring(column_ifexists('NewUsers', '')), |
There was a problem hiding this comment.
Thank you for the review Jason, I just tested, it works as well after I remove tostring.
Looking at the original parser, NewUsersCount, MeetingsCount, ParticipantsCount use column_ifexists with a string default '', so I added tostring here, just tested without it, also works fine.
I tested the parser in 3 different scenarios: 1) only ccf, 2) only azure function, and 3) both exists in the same workspace(alex-prd-rg/providers/Microsoft.OperationalInsights/workspaces/alexZoomCCFGAws/logs), this parser works as expected.
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Yes
Testing Completed:
Yes
Checked that the validations are passing and have addressed any issues that are present: