Skip to content

Microsoft Defender XDR connector: add 'Microsoft Defender XDR' to Pro…#14380

Open
juanjosalco wants to merge 1 commit into
Azure:masterfrom
juanjosalco:juansala/icm-998563-mdxdr-productname
Open

Microsoft Defender XDR connector: add 'Microsoft Defender XDR' to Pro…#14380
juanjosalco wants to merge 1 commit into
Azure:masterfrom
juanjosalco:juansala/icm-998563-mdxdr-productname

Conversation

@juanjosalco

@juanjosalco juanjosalco commented May 29, 2026

Copy link
Copy Markdown

Fixes ICM 21000000998563.

Post-rebrand, Microsoft Defender XDR alerts arrive in SecurityAlert with ProductName = "Microsoft Defender XDR", but the MicrosoftThreatProtection connector definition only filters on the legacy product names (MDATP, O365 ATP, Azure ATP, MCAS, Microsoft 365 Defender). As a result:

The connector status icon renders grey/disconnected for SecurityAlert because lastDataReceivedQuery returns 0 rows, even though data is flowing.
The "Total data received" graph (graphQueries.baseQuery) and the "All Microsoft Defender XDR alerts" sample query (sampleQueries.query) miss the rebranded alerts.
Other data types (DeviceEvents, etc.) are unaffected because their queries don't filter on ProductName.

Change(s):

Added "Microsoft Defender XDR" to the ProductName in (...) list in 3 places in Solutions/Microsoft Defender XDR/Data Connectors/MicrosoftThreatProtection.JSON: - graphQueries[].baseQuery (Alerts metric)

sampleQueries[].query ("All Microsoft Defender XDR alerts")

dataTypes[].lastDataReceivedQuery for SecurityAlert

Mirrored the same 4 changes in the generated Solutions/Microsoft Defender XDR/Package/mainTemplate.json so the packaged solution stays consistent.

Reason for Change(s):

Resolves connector status displaying grey/disconnected for the Microsoft Defender XDR connector after the product rebrand.

Resolves ICM 21000000998563.

Version Updated:

No

Testing Completed:

Testing is planned to happen in Canary after the PR is merged as this PR doesn't introduce any dangerous change

Checked that the validations are passing and have addressed any issues that are present:

Yes

@juanjosalco juanjosalco requested review from a team as code owners May 29, 2026 18:56
@juanjosalco

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree company="Microsoft"

@v-maheshbh v-maheshbh added the Solution Solution specialty review needed label Jun 1, 2026
@v-shukore v-shukore requested a review from Copilot June 8, 2026 06:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the Microsoft Defender XDR data connector queries to include the post-rebrand SecurityAlert.ProductName = "Microsoft Defender XDR" so connector status/metrics and sample alert queries reflect current data.

Changes:

  • Extended SecurityAlert ProductName in (...) filters to include "Microsoft Defender XDR" in the connector definition.
  • Mirrored the same query updates into the packaged mainTemplate.json so the shipped package reflects the connector changes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
Solutions/Microsoft Defender XDR/Data Connectors/MicrosoftThreatProtection.JSON Adds "Microsoft Defender XDR" to SecurityAlert filters for graph metric, sample query, and lastDataReceivedQuery.
Solutions/Microsoft Defender XDR/Package/mainTemplate.json Mirrors the same SecurityAlert filter updates in the generated package template.

Comment thread Solutions/Microsoft Defender XDR/Package/mainTemplate.json
Comment thread Solutions/Microsoft Defender XDR/Package/mainTemplate.json
Comment thread Solutions/Microsoft Defender XDR/Package/mainTemplate.json
Comment thread Solutions/Microsoft Defender XDR/Package/mainTemplate.json
@juanjosalco juanjosalco force-pushed the juansala/icm-998563-mdxdr-productname branch from 50cb46b to edabab3 Compare June 8, 2026 18:22
@juanjosalco

Copy link
Copy Markdown
Author

@v-shukore I addressed Copilot's feedback by regenerating the Package/ artifacts via Tools/Create-Azure-Sentinel-Solution/V3/createSolutionV3.ps1 instead of hand-editing mainTemplate.json.

However, the script produced a much larger diff than my actual change. Beyond my intended 4-line ProductName update, the regenerated mainTemplate.json includes:

  • apiVersion bumps from 2022-10-01 → 2025-07-01 across ~327 resources
  • Property reordering across many unrelated connector blocks (connectorId, columnName, identifier, entityType, etc.)
  • A few new fields the current tool emits (groupByAlertDetails, groupByCustomDetails)

The content is functionally equivalent to what's already in master, it's just reorganized/reformatted by the newer tooling version.

Is this expected output and safe to commit as part of this ICM hotfix, or should I scope the PR down to only my targeted edits and leave the broader regeneration for a separate PR? Happy to go either way, just want to confirm before continuing

@juanjosalco juanjosalco requested a review from Copilot June 10, 2026 00:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.

@v-shukore

Copy link
Copy Markdown
Contributor

Hi @juanjosalco, thanks for your update. I'll review the PR and let you know if anything required. Thanks!

@v-shukore

Copy link
Copy Markdown
Contributor

Hi @juanjosalco, please resolve arm-ttk failure causing due to hardcoded values please update it. Thanks!
image

…ductName filter

Fixes ICM 21000000998563. Post-rebrand alerts arrive with ProductName='Microsoft Defender XDR', which was missing from the SecurityAlert queries in the MicrosoftThreatProtection connector definition. This caused the connector status (lastDataReceivedQuery) to show grey/disconnected and the 'Total data received' chart / sample query to miss alerts.

Updated lastDataReceivedQuery, graphQueries baseQuery, and sampleQueries query in MicrosoftThreatProtection.JSON, plus the matching entries in Package/mainTemplate.json.
@juanjosalco juanjosalco force-pushed the juansala/icm-998563-mdxdr-productname branch from edabab3 to b58de3d Compare June 12, 2026 16:37
@juanjosalco

Copy link
Copy Markdown
Author

Hi @juanjosalco, please resolve arm-ttk failure causing due to hardcoded values please update it. Thanks! image

@v-shukore I've looked into it and it seems it's not a problem my code introduced. I ran the same validation in the master branch (without my code) and I got the same error.

@juanjosalco juanjosalco force-pushed the juansala/icm-998563-mdxdr-productname branch 2 times, most recently from eb491ef to 9e79146 Compare June 18, 2026 06:51
@v-shukore

Copy link
Copy Markdown
Contributor

Hi @juanjosalco, please don't delete the old zip with version 3.0.15 file in the solution as it is and remove that commit so we can proceed. Thanks!

@juanjosalco juanjosalco force-pushed the juansala/icm-998563-mdxdr-productname branch 3 times, most recently from 96c6715 to b58de3d Compare June 19, 2026 17:04
@juanjosalco

Copy link
Copy Markdown
Author

Done @v-shukore thank you for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Solution Solution specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants