Add GitHub audit log fields azstorage#14561
Conversation
Fix run-arm-ttk failure for SonraiSecurity mainTemplate
…es, request_method, query_string, request_body, status_code, url_path, route, rate_limit_remaining fields to DCR and table
… new fields - Add table_GitHubAuditLogsV3.json with 242 fields (all V2 fields + 10 new: repository, repository_id, token_scopes, request_method, query_string, request_body, status_code, url_path, route, rate_limit_remaining) - Revert table_GitHubAuditLogsV2.json to original (no new fields added) - Update DCR.json: outputStream -> Custom-GitHubAuditLogsV3_CL, add 10 new stream declaration columns and transformKql project mappings - Update ConnectorDefinition.json and PollingConfig.json: V2->V3 table refs - Update mainTemplate.json: AzStorage connector and GitHubAuditData function references updated to V3; CCF connector references left on V2
- Update mainTemplate.json: all remaining CCF connector sections V2->V3 - Update GitHubAuditLogs_CCF source files: V2->V3 across ConnectorDefinition, DCR, PollerConfig, and Table
…o V3" This reverts commit 0c97ac7.
…nto add-github-audit-log-fields-azstorage
TwistedAlex
left a comment
TwistedAlex
left a comment
There was a problem hiding this comment.
please update the release note.
|
updated release note |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR bumps the GitHub solution version and introduces a new V3 custom table for the AzStorage GitHub Audit Logs connector to include additional api.request fields.
Changes:
- Bumped solution version to 3.3.2 and added release notes entry.
- Added a new
GitHubAuditLogsV3_CLtable schema containing expanded fields. - Updated AzStorage connector configuration to write/query against
GitHubAuditLogsV3_CLand added new DCR mappings.
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Solutions/GitHub/data/Solution_GitHub.json | Version bump to 3.3.2 for the release containing the schema expansion. |
| Solutions/GitHub/ReleaseNotes.md | Adds 3.3.2 changelog entry describing new api.request fields + V3 table. |
| Solutions/GitHub/Data Connectors/GitHubAuditLogs_AzStorage/table_GitHubAuditLogsV3.json | Introduces the V3 custom table schema with additional request-related columns. |
| Solutions/GitHub/Data Connectors/GitHubAuditLogs_AzStorage/PollingConfig.json | Points the polling config to the V3 datatype used by the connector. |
| Solutions/GitHub/Data Connectors/GitHubAuditLogs_AzStorage/DCR.json | Adds new source fields + updates output stream and transformKQL to project new columns. |
| Solutions/GitHub/Data Connectors/GitHubAuditLogs_AzStorage/ConnectorDefinition.json | Updates queries/metrics to reference the V3 table. |
|
Hi @fuqing04, I ran arm-ttk locally and its failing for some empty properties could you please look into it and resolve this to proceed? |
@v-shukore updated. |
@v-shukore fixed, can you re-approve? |
|
Hi @fuqing04, I noticed that creteui and maintemplate are different inside and outside the zip package. Please ensure they are consistent. Thanks!! |
@v-shukore updated. could you re-review? |
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
