Refactoring Logstash plugin directory into old and new directories for deprecated and active versions of the plugin#14597
Open
ayoubkdib wants to merge 2 commits into
Conversation
…r deprecated and active versions of the plugin
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refactors Logstash plugin documentation to separate the deprecated Ruby (1.x) version from the newer Java (2.x) version by adding a new docs directory and adding deprecation notices/links in the legacy docs.
Changes:
- Added a new
..._javadirectory containing README and CHANGELOG for the Java-based plugin. - Updated the Ruby plugin README/CHANGELOG to clearly mark it as deprecated and link to the Java documentation.
- Reverted Ruby docs to their 1.x context and removed/rewrote sections to align with deprecated status.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| DataConnectors/microsoft-sentinel-log-analytics-logstash-output-plugin_java/README.md | New Java-version documentation (install/config/auth/options). |
| DataConnectors/microsoft-sentinel-log-analytics-logstash-output-plugin_java/CHANGELOG.md | New Java-version changelog including pointer to deprecated Ruby changelog. |
| DataConnectors/microsoft-sentinel-log-analytics-logstash-output-plugin/README.md | Adds deprecation banner and rewrites sections to reflect Ruby 1.x usage. |
| DataConnectors/microsoft-sentinel-log-analytics-logstash-output-plugin/CHANGELOG.md | Replaces 2.x entries with deprecation banner and keeps Ruby 1.2.0 entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: