Update ASIM skills for entity placeholders - #14776
Open
michaelatmsft wants to merge 2 commits into
Open
Conversation
Require generated and reviewed parsers to emit empty entityKey, AdditionalIds, and additionalEntities fields until mappings are defined. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f8c570d9-99f0-4316-af2d-d91b70cce8e4
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the ASIM parser creation and PR review skills to require placeholder entity fields in parser outputs until mappings are defined.
Changes:
- Add reviewer guidance to verify placeholder entity fields in parameter-less parsers.
- Add reviewer guidance to ensure parameterized parsers preserve the same placeholder entity fields.
- Add creation guidance requiring
entityKey,AdditionalIds, andadditionalEntitiesplaceholders in all new parsers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/skills/asim-parser-pr-reviewer/SKILL.md | Adds PR review checklist items for verifying placeholder entity fields in both parameter-less and parameterized parsers. |
| .github/skills/asim-parser-create-parser/SKILL.md | Specifies required placeholder entity fields and their default empty values in newly created parsers. |
hunngu-ms
reviewed
Jul 29, 2026
Derive role-specific entity placeholder fields from the target and Common schemas, preserve exact casing, and clarify review behavior across parser variants. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f8c570d9-99f0-4316-af2d-d91b70cce8e4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ASimTester.csvPlaceholder behavior
Commonrows*EntityKeyis emitted as an empty string*AdditionalIdsfield andAdditionalEntitiesis emitted as an empty dynamic arrayDependency
The entity field definitions follow the schema changes proposed in #14628. This PR should merge after #14628, or be reconciled with its final field inventory if that proposal changes.