Skip to content

Restrict unsupported patterns in ASIM parser skills - #14797

Draft
michaelatmsft wants to merge 3 commits into
Azure:masterfrom
michaelatmsft:michaelatmsft/asim-parser-restrictions
Draft

Restrict unsupported patterns in ASIM parser skills#14797
michaelatmsft wants to merge 3 commits into
Azure:masterfrom
michaelatmsft:michaelatmsft/asim-parser-restrictions

Conversation

@michaelatmsft

Copy link
Copy Markdown
Contributor

Summary

  • keep ASIM parser creation as a single-source, per-record normalization pipeline
  • prohibit same-table and cross-table enrichment, including inline table-shaped mappings
  • prohibit one-to-many fan-out, all mv-* operators, and aggregation or reaggregation
  • add matching High-priority checks to the ASIM PR reviewer for both ASim and vim parsers

DCR gap analysis alignment

This applies the guidance from section 6 of AsimDcrGapAnalysis.pdf:

  • no same-table or cross-table enrichment
  • no normalization fan-out from one source record to multiple records
  • no mv-* followed by summarize or other aggregation/reaggregation patterns

Stacked dependency

This draft PR is stacked on #14776. It currently includes that PR's commits in its comparison and should not merge first.

After #14776 merges, rebase this branch onto the latest master and verify the PR contains only commit 93141dda79 (or its rebased equivalent) and the three ASIM skill-file changes.

Validation

  • Prettier 1.19.1 formatting check
  • skill YAML frontmatter check
  • git diff --check

Require generated and reviewed parsers to emit empty entityKey, AdditionalIds, and additionalEntities fields until mappings are defined.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f8c570d9-99f0-4316-af2d-d91b70cce8e4
Derive role-specific entity placeholder fields from the target and Common schemas, preserve exact casing, and clarify review behavior across parser variants.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f8c570d9-99f0-4316-af2d-d91b70cce8e4
Prohibit enrichment, fan-out, mv-* operators, and aggregation in ASIM parser creation and review guidance.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 626b2a6f-5699-493d-bfa5-0c490bf1f420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants