Skip to content

Commit 4fa99cb

Browse files
committed
address comments
1 parent 29e81e7 commit 4fa99cb

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

docs/content/contributing/bicep/bicep-contribution-flow/child-module-publishing.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ For a step-by-step explanation with detailed instructions, refer to the followin
3939
* **Parent module template**: In the `main.bicep` template of the child module direct parent, add a `enableReferencedModulesTelemetry` variable with a value of `false`, and pass it as the `enableTelemetry` value down to the child module deployment.
4040
* **Version**: Add the `version.json` file to the child module folder and set version to `0.1`.
4141
* **Changelog**: Add a new `CHANGELOG.md` file to the child module folder and update the changelog of all its versioned parents with a new patch version, up to the top-level parent.
42-
* **Set-AVMModule**: Run [Set-AVMModule](https://github.com/Azure/bicep-registry-modules/blob/main/utilities/tools/Set-AVMModule.ps1), test your changes, raise a PR.
42+
* **Set-AVMModule**: Run the [Set-AVMModule](https://github.com/Azure/bicep-registry-modules/blob/main/utilities/tools/Set-AVMModule.ps1) utility using the `-Recurse` flag and the path to the top-level module, test your changes and raise a PR.
4343

4444
For more detailed guidance, please refer below.
4545

@@ -101,7 +101,7 @@ Please follow the steps below:
101101
- Add the `avmTelemetry` deployment, referencing below template. Make sure to replace the `<ReplaceWith-TelemetryIdPrefix>` placeholder with the assigned telemetry ID prefix value that you noted down when checking prerequisites.
102102
```bicep
103103
#disable-next-line no-deployments-resources
104-
resource avmTelemetry 'Microsoft.Resources/deployments@2024-03-01' = if (enableTelemetry) {
104+
resource avmTelemetry 'Microsoft.Resources/deployments@2025-04-01' = if (enableTelemetry) {
105105
name: '<ReplaceWith-TelemetryIdPrefix>.${replace('-..--..-', '.', '-')}.${substring(uniqueString(deployment().name), 0, 4)}'
106106
properties: {
107107
mode: 'Incremental'
@@ -152,7 +152,7 @@ Please follow the steps below:
152152

153153
- None
154154
```
155-
- Update the changelog of all the child module versioned parents with a new patch version, up to the top-level parent. Refer below for an example content section:
155+
- Update the changelog of all the child module's versioned parents with a new patch version, up to the top-level parent. Refer below for an example content section:
156156
```markdown
157157
## <CurrentMajor>.<CurrentMinor>.<CurrentPatch+1>
158158

@@ -165,7 +165,7 @@ Please follow the steps below:
165165
- None
166166

167167
```
168-
- As per usual pull request process, run the [Set-AVMModule](https://github.com/Azure/bicep-registry-modules/blob/main/utilities/tools/Set-AVMModule.ps1) script, test your changes locally and/or via the top-level module pipeline, raise a PR and attach a status badge proving successful validation.
168+
- As per usual pull request process, run the [Set-AVMModule](https://github.com/Azure/bicep-registry-modules/blob/main/utilities/tools/Set-AVMModule.ps1) utility using the `-Recurse` flag and top-level parent's folder path. Then test your changes locally and/or via the top-level module pipeline, raise a PR and attach a status badge proving successful validation.
169169

170170
{{% notice style="tip" %}}
171171

0 commit comments

Comments
 (0)