Skip to content

Commit 9b88e95

Browse files
authored
module deprecation (#1942)
1 parent 7ffc901 commit 9b88e95

30 files changed

Lines changed: 940 additions & 598 deletions

.github/ISSUE_TEMPLATE/5_orphaned_module.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
name: Orphaned AVM Module 👀
1+
name: Orphaned AVM Module 🟡
22
description: An existing AVM module has just become orphaned and needs a new owner
33
title: "[Orphaned Module]: `MODULE_NAME_BETWEEN_BACKTICKS`"
4-
labels: ["Status: Module Orphaned :eyes:", "Needs: Module Owner :mega:", "Needs: Triage :mag:"]
4+
labels: ["Status: Module Orphaned :yellow_circle:", "Needs: Module Owner :mega:", "Needs: Triage :mag:"]
55
projects: ["Azure/529"]
66
body:
77
- type: markdown
Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,68 @@
1+
name: Deprecate AVM Module 🔴
2+
description: Want to deprecate an AVM Module? Let us know!
3+
title: "[Module Deprecation]: `MODULE_NAME_BETWEEN_BACKTICKS`"
4+
labels: ["Status: Module Deprecated :red_circle:", "Needs: Triage :mag:"]
5+
projects: ["Azure/529"]
6+
body:
7+
- type: markdown
8+
attributes:
9+
value: |
10+
By filling this issue template, you're requesting a given AVM module to be [deprecated](https://azure.github.io/Azure-Verified-Modules/specs/shared/module-lifecycle/#deprecated-modules).
11+
12+
This request should primarily be submitted by the module owner, but can be submitted by anyone. The module owner will be contacted to confirm the deprecation request.
13+
14+
- type: checkboxes
15+
id: existing-checks
16+
attributes:
17+
label: Check for previous/existing GitHub issues/deprecation requests
18+
description: By submitting this issue, you confirm that you have [searched for previous/existing GitHub issues/module deprecation requests](https://github.com/Azure/Azure-Verified-Modules/issues?q=is%3Aissue+sort%3Aupdated-desc+) to avoid creating a duplicate.
19+
options:
20+
- label: I have checked for previous/existing GitHub issues/module deprecation requests.
21+
required: true
22+
- type: checkboxes
23+
id: existing-module-from-elsewhere
24+
attributes:
25+
label: Check this module isn't already deprecated in the module indexes
26+
description: By submitting this issue, you confirm that you have checked the [Bicep](https://azure.github.io/Azure-Verified-Modules/indexes/bicep/) or [Terraform](https://azure.github.io/Azure-Verified-Modules/indexes/terraform/) module indexes for the module you are requesting to be deprecated.
27+
options:
28+
- label: I have checked for that this module isn't already deprecated.
29+
required: true
30+
- type: dropdown
31+
id: language
32+
attributes:
33+
label: Bicep or Terraform?
34+
description: Is this a Bicep or a Terraform module? (Please submit a separate deprecation request for each language!)
35+
options:
36+
- Bicep
37+
- Terraform
38+
validations:
39+
required: true
40+
- type: input
41+
id: module-name
42+
attributes:
43+
label: Module Name
44+
description: |
45+
Please provide the exact name of the module you're requesting to be deprecated.
46+
placeholder: '<Module name>'
47+
validations:
48+
required: true
49+
- type: textarea
50+
id: module-details
51+
attributes:
52+
label: Module Details
53+
description: Let us know why this module should be deprecated!
54+
validations:
55+
required: true
56+
- type: input
57+
id: owner-gh-un
58+
attributes:
59+
label: Module Owner's GitHub Username (handle)
60+
description: Please provide the GitHub handle of the current module owner!
61+
validations:
62+
required: false
63+
- type: markdown
64+
attributes:
65+
value: |
66+
> **NOTE**:
67+
>
68+
> - This module deprecation request issue **MUST remain open** until the module deprecation process if fully completed. **Do NOT close** the issue before receiving confirmation from the AVM Core team!

docs/content/help-support/issue-triage/avm-issue-triage.md

Lines changed: 38 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -164,13 +164,7 @@ Once module is developed and `v0.1.0` has been published to the relevant registr
164164

165165
### When a module becomes orphaned
166166

167-
If a module meets the criteria described in the "[Orphaned AVM Modules]({{% siteparam base %}}/specs/shared/module-lifecycle/#orphaned-avm-modules)" chapter, the modules is considered to be orphaned and the below steps must be performed.
168-
169-
An issue is considered to be an orphaned module if
170-
171-
- it was opened through the "[Orphaned AVM Module 👀](https://aka.ms/avm/OrphanedModule)" template,
172-
- it has the labels of &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#FBCA04;">Needs: Triage 🔍</mark>&nbsp;, &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#FF0019;color:white;">Needs: Module Owner 📣</mark>&nbsp; and the &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#F4A460;">Status: Module Orphaned 👀</mark>&nbsp; applied to it, and
173-
- it is assigned to the "[AVM - Module Triage](https://github.com/orgs/Azure/projects/529)" GitHub project.
167+
If a module meets the criteria described in the "[Orphaned Modules]({{% siteparam base %}}/specs/shared/module-lifecycle/#3-orphaned-avm-modules)" chapter, the module is considered to be orphaned and the below steps must be performed.
174168

175169
{{% notice style="note" %}}
176170
The original **Module Proposal issue** related to the module in question **MUST remain closed and intact**.
@@ -180,8 +174,8 @@ Instead, a **new Orphaned Module issue** must be opened that **MUST remain open*
180174
Once the **Orphaned Module issue** was closed, it **MUST remain closed**. If the module will subsequently become orphaned again, a new Orphaned Module issue must be opened.
181175
{{% /notice %}}
182176

183-
1. Create a new issue using the "[Orphaned AVM Module 👀](https://aka.ms/AVM/OrphanedModule)" issue template.
184-
2. Make sure the &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#FBCA04;">Needs: Triage 🔍</mark>&nbsp;, &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#FF0019;color:white;">Needs: Module Owner 📣</mark>&nbsp;, and the &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#F4A460;">Status: Module Orphaned 👀</mark>&nbsp; labels are assigned to the issue.
177+
1. Submit an "orphaned module" issue by using the "[Orphaned AVM Module 🟡](https://aka.ms/AVM/OrphanedModule)" issue template.
178+
2. Make sure the &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#FBCA04;">Needs: Triage 🔍</mark>&nbsp;, &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#FF0019;color:white;">Needs: Module Owner 📣</mark>&nbsp;, and the &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#F4A460;">Status: Module Orphaned 🟡</mark>&nbsp; labels are assigned to the issue and it is assigned to the "[AVM - Module Triage](https://github.com/orgs/Azure/projects/529)" GitHub project.
185179
3. Move the issue into the "`Orphaned`" column on the [AVM - Modules Triage](https://aka.ms/avm/moduletriage) GitHub Project board.
186180
4. Update the AVM Module Indexes, following the [process documented internally](https://dev.azure.com/CSUSolEng/Azure%20Verified%20Modules/_wiki/wikis/AVM%20Internal%20Wiki/684/Module-index-update-process).
187181
5. Place an information notice as per the below guidelines:
@@ -196,7 +190,7 @@ Include the following text in the information notice:
196190

197191
{{% expand title="➕ Orphaned module notice for module README file" %}}
198192

199-
{{< highlight lineNos="false" type="markdown" wrap="true" title="" >}}
193+
{{< highlight lineNos="false" type="markdown" wrap="true" title="ORPHANED.md" >}}
200194

201195
{{% include file="/static/includes/orphaned-module-notice.md" %}}
202196

@@ -211,7 +205,7 @@ Include the following text in the information notice:
211205
{{% notice style="tip" %}}
212206
To look for Orphaned Modules:
213207

214-
- Click on the following link to use this saved query ➡️ <a href="https://aka.ms/avm/OrphanedModules">&nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#F4A460;">Status: Module Orphaned 👀</mark>&nbsp;</a> ⬅️.
208+
- Click on the following link to use this saved query ➡️ <a href="https://aka.ms/avm/OrphanedModules">&nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#F4A460;">Status: Module Orphaned 🟡</mark>&nbsp;</a> ⬅️.
215209
- Check the `Orphaned` swim lane on the [Module Triage board](https://aka.ms/avm/moduletriage).
216210
{{% /notice %}}
217211

@@ -230,7 +224,7 @@ To look for Orphaned Modules:
230224

231225
2. Once the new module owner candidate has confirmed they understand and accept their roles and responsibilities as an AVM module owner
232226
- Assign the issue to the confirmed module owner.
233-
- Remove the &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#F4A460;">Status: Module Orphaned 👀</mark>&nbsp; and the &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#FF0019;color:white;">Needs: Module Owner 📣</mark>&nbsp; labels from the issue.
227+
- Remove the &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#F4A460;">Status: Module Orphaned 🟡</mark>&nbsp; and the &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#FF0019;color:white;">Needs: Module Owner 📣</mark>&nbsp; labels from the issue.
234228
- Add the &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#C8E6C9;">Status: Module Available 🟢</mark>&nbsp; and &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#FBEF2A;">Status: Owners Identified 🤘</mark>&nbsp; labels to the issue.
235229
- Move the issue into the "`Done`" column on the [AVM - Modules Triage](https://aka.ms/avm/moduletriage) GitHub Project board.
236230
3. Update the AVM Module Indexes, following the [process documented internally](https://dev.azure.com/CSUSolEng/Azure%20Verified%20Modules/_wiki/wikis/AVM%20Internal%20Wiki/684/Module-index-update-process).
@@ -256,6 +250,38 @@ To look for Orphaned Modules:
256250

257251
7. Close the Orphaned Module issue.
258252

253+
## Deprecated modules
254+
255+
### When a module becomes deprecated
256+
257+
If a module meets the criteria described in the "[Deprecated Modules]({{% siteparam base %}}/specs/shared/module-lifecycle/#4-deprecated-modules)" chapter, the module is considered to be deprecated and the below steps must be performed.
258+
259+
1. Submit a "deprecated module" issue by using the "[Deprecate AVM Module 🔴](https://aka.ms/avm/DeprecatedModule)" issue template.
260+
2. Make sure the &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#FBCA04;">Needs: Triage 🔍</mark>&nbsp; and the &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#000000;color:white;">Status: Module Deprecated 🔴</mark>&nbsp; labels are assigned to the issue and it is assigned to the "[AVM - Module Triage](https://github.com/orgs/Azure/projects/529)" GitHub project.
261+
3. Update the AVM Module Indexes, following the [process documented internally](https://dev.azure.com/CSUSolEng/Azure%20Verified%20Modules/_wiki/wikis/AVM%20Internal%20Wiki/684/Module-index-update-process).
262+
4. Place an information notice as per the below guidelines:
263+
- In case of a Bicep module:
264+
- Place the information notice - with the text below - in an `DEPRECATED.md` file, in the module's root.
265+
- Run the [`utilities/tools/Set-AVMModule.ps1`](https://github.com/Azure/bicep-registry-modules/blob/main/utilities/tools/Set-AVMModule.ps1) utility with the module path as an input. This re-generates the module’s `README.md` file, so that the `README.md` file will also contain the same notice in its header.
266+
- Make sure the content of the `DEPRECATED.md` file is displayed in the `README.md` in its header (right after the title).
267+
- Publish a new patch version, having the updated `README.md` stating the module is deprecated.
268+
- In case of a Terraform module:
269+
- Place the information notice - with the text below - in the `README.md` file, in the module's root.
270+
- Archive the module's repository on GitHub.
271+
- Once the information notice is placed, submit a Pull Request.
272+
273+
Place the following information notice in the module's repository:
274+
275+
{{% expand title="➕ Deprecated module indicators" %}}
276+
277+
{{< highlight lineNos="false" type="markdown" wrap="true" title="DEPRECATED.md" >}}
278+
279+
{{% include file="/static/includes/deprecated-module-notice.md" %}}
280+
281+
{{< /highlight >}}
282+
283+
{{% /expand %}}
284+
259285
## General feedback/question, documentation update and other standard issues
260286

261287
An issue is a "General Question/Feedback ❔" if it was opened through the ["General Question/Feedback ❔"](https://github.com/Azure/Azure-Verified-Modules/issues/new?assignees=&labels=Type%3A+Question%2FFeedback+%3Araising_hand%3A&projects=&template=question_feedback.yml&title=%5BQuestion%2FFeedback%5D%3A+) issue template, and has the labels of &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#CB6BA2;color:white;">Type: Question/Feedback 🙋‍♀️</mark>&nbsp; and &nbsp;<mark style="background-image:none;white-space: nowrap;background-color:#FBCA04;">Needs: Triage 🔍</mark>&nbsp; applied to it.

docs/content/indexes/_index.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,20 @@ The following table shows the number of all available, orphaned and planned **AV
1212

1313
{{% moduleStats language="All" moduleType="All" showLanguage=true showClassification=true %}}
1414

15+
{{% expand title="➕ Additional information" %}}
16+
17+
{{% notice style="grey" title="Legend" %}}
18+
{{% include file="/static/includes/module-status-legend.md" %}}
19+
{{% /notice %}}
20+
21+
{{% /expand %}}
22+
1523
{{% notice style="tip" title="Want to contribute to AVM modules?" %}}
1624

1725
| # | <div style="width:250px">Labels</div> | Link and description |
1826
| -------- | -------- | -------- |
1927
| 1. | <mark style="background-image:none;white-space: nowrap;background-color:#ADD8E6;">Type: New Module Proposal 💡</mark> <br> <mark style="background-image:none;white-space: nowrap;background-color:#FF0019;color:white;">Needs: Module Owner 📣</mark> | To become the **owner of a new module**, see [all new modules looking for owners](https://aka.ms/AVM/NeedsModuleOwner) or check out the "*Looking for owners*" swimlane [here](https://aka.ms/AVM/NeedsModuleOwner/Project). |
20-
| 2. | <mark style="background-image:none;white-space: nowrap;background-color:#F4A460;">Status: Module Orphaned 👀</mark> | To become the **owner of an orphaned module**, see [all orphaned modules](https://aka.ms/AVM/OrphanedModules) or check out the "*Orphaned*" swimlane [here](https://aka.ms/AVM/OrphanedModules/Project). |
28+
| 2. | <mark style="background-image:none;white-space: nowrap;background-color:#F4A460;">Status: Module Orphaned 🟡</mark> | To become the **owner of an orphaned module**, see [all orphaned modules](https://aka.ms/AVM/OrphanedModules) or check out the "*Orphaned*" swimlane [here](https://aka.ms/AVM/OrphanedModules/Project). |
2129
| 3. | <mark style="background-image:none;white-space: nowrap;background-color:#C95474;color:white;">Needs: Module Contributor 📣</mark> | To become a **co-owner or contribute to a module**, see [all modules looking for contributors](https://aka.ms/AVM/NeedsModuleContributor). |
2230

2331
For more details on "**What are the different ways to contribute to AVM?**", see [here]({{% siteparam base %}}/faq/#are-there-different-ways-to-contribute-to-avm).

docs/content/indexes/bicep/_index.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,20 @@ The following table shows the number of all available, orphaned and planned **Bi
1212

1313
{{% moduleStats language="Bicep" moduleType="All" showLanguage=true showClassification=true %}}
1414

15+
{{% expand title="➕ Additional information" %}}
16+
17+
{{% notice style="grey" title="Legend" %}}
18+
{{% include file="/static/includes/module-status-legend.md" %}}
19+
{{% /notice %}}
20+
21+
{{% /expand %}}
22+
1523
{{% notice style="tip" title="Want to contribute to AVM Bicep modules?" %}}
1624

1725
| # | Labels | Link and description |
1826
| -------- | -------- | -------- |
1927
| 1. | <mark style="background-image:none;white-space: nowrap;background-color:#ADD8E6;">Type: New Module Proposal 💡</mark> <br> <mark style="background-image:none;white-space: nowrap;background-color:#FF0019;color:white;">Needs: Module Owner 📣</mark> <br> <mark style="background-image:none;white-space: nowrap;background-color:#1D73B3;color:white;">Language: Bicep 💪</mark> | To become the **owner of a new Bicep module**, see [all new Bicep modules looking for owners](https://aka.ms/AVM/Bicep/NeedsModuleOwner) or check out the "*Looking for owners*" swimlane [here](https://aka.ms/AVM/Bicep/NeedsModuleOwner/Project). |
20-
| 2. | <mark style="background-image:none;white-space: nowrap;background-color:#F4A460;">Status: Module Orphaned 👀</mark> <mark style="background-image:none;white-space: nowrap;background-color:#1D73B3;color:white;">Language: Bicep 💪</mark> | To become the **owner of an orphaned Bicep module**, see [all orphaned Bicep modules](https://aka.ms/AVM/Bicep/OrphanedModules) or check out the "*Orphaned*" swimlane [here](https://aka.ms/AVM/Bicep/OrphanedModules/Project). |
28+
| 2. | <mark style="background-image:none;white-space: nowrap;background-color:#F4A460;">Status: Module Orphaned 🟡</mark> <mark style="background-image:none;white-space: nowrap;background-color:#1D73B3;color:white;">Language: Bicep 💪</mark> | To become the **owner of an orphaned Bicep module**, see [all orphaned Bicep modules](https://aka.ms/AVM/Bicep/OrphanedModules) or check out the "*Orphaned*" swimlane [here](https://aka.ms/AVM/Bicep/OrphanedModules/Project). |
2129
| 3. | <mark style="background-image:none;white-space: nowrap;background-color:#C95474;color:white;">Needs: Module Contributor 📣</mark> <mark style="background-image:none;white-space: nowrap;background-color:#1D73B3;color:white;">Language: Bicep 💪</mark> | To become a **co-owner or contribute to a Bicep module**, see [all Bicep modules looking for contributors](https://aka.ms/AVM/Bicep/NeedsModuleContributor). |
2230

2331
For more details on "**What are the different ways to contribute to AVM?**", see [here]({{% siteparam base %}}/faq/#are-there-different-ways-to-contribute-to-avm).

0 commit comments

Comments
 (0)