Skip to content

feat: adds bool type to the variable#2121

Closed
ReneHezser wants to merge 1 commit into
mainfrom
reference-modules-telemetry
Closed

feat: adds bool type to the variable#2121
ReneHezser wants to merge 1 commit into
mainfrom
reference-modules-telemetry

Conversation

@ReneHezser

Copy link
Copy Markdown
Contributor

Overview/Summary

Adds the type to the variable, which is not available in Bicep.

var enableReferencedModulesTelemetry bool = false

This PR fixes/adds/changes/removes

Adds to #AB41075

Breaking Changes

none

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@ReneHezser ReneHezser requested a review from a team as a code owner June 11, 2025 13:48
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs: Triage 🔍 Maintainers need to triage still label Jun 11, 2025
@ReneHezser ReneHezser enabled auto-merge (squash) June 12, 2025 06:27

```Bicep
var enableReferencedModulesTelemetry = false
var enableReferencedModulesTelemetry bool = false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we could (re-)visit this decision? I take it these changes are the result of a previous core team call?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I'll put it on the agenda again.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the comment in the spec PR I'd suggest closing this one IF agreed upon

@ReneHezser ReneHezser marked this pull request as draft June 16, 2025 13:48
auto-merge was automatically disabled June 16, 2025 13:48

Pull request was converted to draft

@ReneHezser ReneHezser closed this Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Triage 🔍 Maintainers need to triage still

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants