cmd/ie/commands/to-bash: Propagate error instead of exiting

Signed-off-by: Jose Blanquicet <josebl@microsoft.com>

Author: blanquicet

cmd/ie/commands/to-bash.go

@@ -2,12 +2,11 @@ package commands
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
-	"os"
 	"strings"
 
 	"github.com/Azure/InnovationEngine/internal/engine"
-	"github.com/Azure/InnovationEngine/internal/logging"
 	"github.com/spf13/cobra"
 )
 
@@ -18,12 +17,10 @@ type OcdScript struct {
 var toBashCommand = &cobra.Command{
 	Use:   "to-bash",
 	Short: "Convert a markdown scenario into a bash script.",
-	Run: func(cmd *cobra.Command, args []string) {
+	RunE: func(cmd *cobra.Command, args []string) error {
 		markdownFile := args[0]
 		if markdownFile == "" {
-			logging.GlobalLogger.Errorf("Error: No markdown file specified.")
-			cmd.Help()
-			os.Exit(1)
+			return errors.New("no markdown file specified")
 		}
 
 		environment, _ := cmd.Flags().GetString("environment")
@@ -34,10 +31,7 @@ var toBashCommand = &cobra.Command{
 		for _, environmentVariable := range environmentVariables {
 			keyValuePair := strings.SplitN(environmentVariable, "=", 2)
 			if len(keyValuePair) != 2 {
-				logging.GlobalLogger.Errorf("Error: Invalid environment variable format: %s", environmentVariable)
-				fmt.Printf("Error: Invalid environment variable format: %s", environmentVariable)
-				cmd.Help()
-				os.Exit(1)
+				return fmt.Errorf("invalid environment variable format: %s", environmentVariable)
 			}
 
 			cliEnvironmentVariables[keyValuePair[0]] = keyValuePair[1]
@@ -48,28 +42,23 @@ var toBashCommand = &cobra.Command{
 			markdownFile,
 			[]string{"bash", "azurecli", "azurecli-interactive", "terraform"},
 			cliEnvironmentVariables)
-
 		if err != nil {
-			logging.GlobalLogger.Errorf("Error creating scenario: %s", err)
-			fmt.Printf("Error creating scenario: %s", err)
-			os.Exit(0)
+			return fmt.Errorf("creating scenario: %w", err)
 		}
 
 		if environment == "ocd" {
 			script := OcdScript{Script: scenario.ToShellScript()}
 			scriptJson, err := json.Marshal(script)
-
 			if err != nil {
-				logging.GlobalLogger.Errorf("Error converting to json: %s", err)
-				fmt.Printf("Error converting to json: %s", err)
-				os.Exit(1)
+				return fmt.Errorf("converting to json: %w", err)
 			}
 
 			fmt.Printf("ie_us%sie_ue\n", scriptJson)
 		} else {
 			fmt.Printf("%s", scenario.ToShellScript())
 		}
 
+		return nil
 	},
 }