fix: docs, VS Code CI, and cleanup improvements

- Fix VSCE_PAT check: use secrets context instead of step-level env
  (step env not available at if: evaluation time)
- Pin microsoft/ps-docs to SHA (was @main, supply chain risk)
- Fix site_url in mkdocs.yml to actual published docs URL
- Delete inert packages/psdocs/.github/workflows/build.yaml
  (GitHub ignores workflows outside root .github/workflows/)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: vicperdana

.github/workflows/docs.yaml

@@ -32,7 +32,7 @@ jobs:
           git config user.email '41898282+github-actions[bot]@users.noreply.github.com'
 
       - name: Generate docs
-        uses: microsoft/ps-docs@main
+        uses: microsoft/ps-docs@333fc57dfef2479e0c6457600bb4c7a1316783ba # main
         with:
           modules: PSDocs,PSDocs.Azure
           inputPath: packages/psdocs-azure/templates

.github/workflows/vscode-ci.yml

@@ -161,7 +161,7 @@ jobs:
           echo "Found VSIX: $VSIX_FILE"
 
       - name: Publish to VS Marketplace (Pre-release)
-        if: env.VSCE_PAT != ''
+        if: ${{ secrets.VSCE_PAT != '' }}
         working-directory: packages/vscode-extension/out/package
         env:
           VSCE_PAT: ${{ secrets.VSCE_PAT }}

mkdocs.yml

@@ -1,5 +1,5 @@
 site_name: PSDocs for Azure
-site_url: https://github.com/Azure/PSDocs.Azure
+site_url: https://azure.github.io/PSDocs.Azure/
 site_description: Generate documentation from Azure infrastructure as code (IaC) artifacts.
 site_author: Microsoft