Skip to content

Commit d8dca07

Browse files
vicperdanaCopilot
andcommitted
fix(vscode): version-scope all overrides per Copilot review feedback
Address all 4 review comments on PR #414: - Convert previously-unscoped overrides (serialize-javascript, flatted, markdown-it, qs, underscore, diff) to version-scoped form. Each now only applies to versions in the vulnerable range, eliminating the risk of forcing major-version upgrades on out-of-scope consumers. - Bump brace-expansion v1 override target from ^1.1.13 -> ^1.1.14 (and trigger range to <1.1.14) so the override deterministically lands on the version the lockfile already resolved. - Bump minimatch v3 override target from ^3.1.4 -> ^3.1.5 (and trigger range to <3.1.5) for the same deterministic-resolution reason. - Replace blanket diff ^8.0.3 with two scoped ranges: diff@>=5.0.0 <5.2.2 -> ^5.2.2 (patches v5 line in place) diff@>=6.0.0 <8.0.3 -> ^8.0.3 (patches v6/v7 line, matches what mocha 11.7.5 already pulls in) Validation: - npm audit reports 0 vulnerabilities - All 14 originally-flagged alerts remain resolved - npm run compile, lint, pack all clean Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent dc3052e commit d8dca07

2 files changed

Lines changed: 84 additions & 83 deletions

File tree

packages/vscode-extension/package-lock.json

Lines changed: 75 additions & 75 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/vscode-extension/package.json

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -92,17 +92,18 @@
9292
"@vscode/vsce": "^3.7.1"
9393
},
9494
"overrides": {
95-
"serialize-javascript": "^7.0.5",
96-
"flatted": "^3.4.2",
97-
"markdown-it": "^14.1.1",
98-
"qs": "^6.14.2",
99-
"underscore": "^1.13.8",
100-
"diff": "^8.0.3",
95+
"serialize-javascript@<7.0.5": "^7.0.5",
96+
"flatted@<3.4.2": "^3.4.2",
97+
"markdown-it@<14.1.1": "^14.1.1",
98+
"qs@<6.14.2": "^6.14.2",
99+
"underscore@<1.13.8": "^1.13.8",
100+
"diff@>=5.0.0 <5.2.2": "^5.2.2",
101+
"diff@>=6.0.0 <8.0.3": "^8.0.3",
101102
"ajv@<6.14.0": "^6.14.0",
102103
"picomatch@<2.3.2": "^2.3.2",
103-
"brace-expansion@<1.1.13": "^1.1.13",
104+
"brace-expansion@<1.1.14": "^1.1.14",
104105
"brace-expansion@>=2.0.0 <2.0.3": "^2.0.3",
105-
"minimatch@<3.1.4": "^3.1.4",
106+
"minimatch@<3.1.5": "^3.1.5",
106107
"minimatch@>=5.0.0 <5.1.8": "^5.1.8",
107108
"minimatch@>=9.0.0 <9.0.7": "^9.0.7"
108109
}

0 commit comments

Comments
 (0)