Add examples for getting secrets for VMs#56
Merged
BernieWhite merged 13 commits intoJan 13, 2026
Conversation
…com/BernieWhite/PSRule.Rules.Azure-quickstart into bewhite/add-keyvault-secret-example
Collaborator
Author
|
Please review @Tatsinnit. Thanks. |
Tatsinnit
reviewed
Apr 4, 2025
Member
Tatsinnit
left a comment
Tatsinnit
left a comment
There was a problem hiding this comment.
💡 Thank you so much for the kind ping! I've added a few thoughts—though I'm not entirely sure about their full relevance, I do feel it might be helpful to note whether these files are generated by a tool or adapted from somewhere else.
Also, regarding the constants and GUIDs in use—it would be great to document the purpose behind them, especially since they may potentially be referenced by end users. Highlighting any possible downsides or considerations could be valuable too. 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add new examples for working with secrets in the pipeline and key vault.
PR Checklist