add support for Azure container linux by mayankfz · Pull Request #3577 · Azure/WALinuxAgent

mayankfz · 2026-03-09T03:56:58Z

Description

This adds support Azure Container Linux, which is derived from Azure Linux, and is compatible with it.

Issue

PR information

Ensure development PR is based on the develop branch.
If applicable, the PR references the bug/issue that it fixes in the description.
New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

I have read the contribution guidelines.

Distro maintenance information, if applicable

This is a contribution from a distro maintainer
The changes in this PR have been taken as a downstream patch (Note: it is not recommended to patch the agent without upstream review and approval)

mayankfz · 2026-03-24T03:50:26Z

Attaching the waagent logs
ACL_waagent.log

Signed-off-by: Mayank Singh <mayankfz@gmail.com>

Copilot

Pull request overview

Adds packaging/runtime support for Microsoft Azure Container Linux (ACL) (derived from Azure Linux) by installing ACL-specific systemd units and agent configuration when building/installing on that distro.

Changes:

Update setup.py to select ACL-specific config and systemd units when DISTRO_FULL_NAME indicates Azure Container Linux.
Add a new ACL waagent.service systemd unit.
Add an ACL systemd drop-in for multi-user.target and an ACL-specific waagent.conf.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
setup.py	Adds ACL-specific selection logic and installs extra systemd drop-in for ACL.
init/acl/waagent.service	Introduces a new systemd unit for running waagent on ACL.
init/acl/10-waagent-sysext.conf	Adds a `multi-user.target` drop-in intended to keep waagent upheld under sysext usage.
config/acl/waagent.conf	Adds ACL-specific agent defaults (provisioning/resource disk/firewall, etc.).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Mayank Singh <mayankfz@gmail.com>

narrieta · 2026-04-01T16:24:09Z

Attaching the waagent logs ACL_waagent.log

We need to address these errors in the log

2026-03-24T03:42:50.204451Z ERROR Daemon Daemon Failed to mount resource disk [ResourceDiskError] unable to detect disk topology
...
2026-03-24T03:42:53.032311Z ERROR ExtHandler ExtHandler Unable to setup the persistent firewall rules: [Errno 30] Read-only file system: '/usr/lib/systemd/system/waagent-network-setup.service'

mayankfz · 2026-04-02T14:42:23Z

Attaching the waagent logs ACL_waagent.log

We need to address these errors in the log

2026-03-24T03:42:50.204451Z ERROR Daemon Daemon Failed to mount resource disk [ResourceDiskError] unable to detect disk topology
...
2026-03-24T03:42:53.032311Z ERROR ExtHandler ExtHandler Unable to setup the persistent firewall rules: [Errno 30] Read-only file system: '/usr/lib/systemd/system/waagent-network-setup.service'

Fixed.
ACL_waagent_1.log

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Mayank Singh <mayankfz@gmail.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Mayank Singh <mayankfz@gmail.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-03T16:22:08Z

+    # For Azure Container Linux, distro_name is "azurelinux" and distro_full_name is "Microsoft Azure Container Linux".
+    if distro_name == "azurelinux" and distro_full_name == "Microsoft Azure Container Linux":


ACL selection relies on an exact match of distro_full_name ("Microsoft Azure Container Linux"). If the full name differs (extra version/build text, casing, etc.), the agent will fall back to MarinerOSUtil, which uses a different systemd unit install path (/usr/lib/systemd/system) and may be incompatible with ACL’s stated read-only /usr requirement. Consider switching this check to a more tolerant match (e.g., substring/case-insensitive) or a stable identifier rather than the full, human-readable name.

Suggested change

# For Azure Container Linux, distro_name is "azurelinux" and distro_full_name is "Microsoft Azure Container Linux".

if distro_name == "azurelinux" and distro_full_name == "Microsoft Azure Container Linux":

# For Azure Container Linux, distro_name is "azurelinux" and distro_full_name contains

# "Microsoft Azure Container Linux" (it may include additional version/build information).

normalized_distro_full_name = (distro_full_name or "").lower()

if distro_name == "azurelinux" and "azure container linux" in normalized_distro_full_name:

Copilot · 2026-04-03T16:22:09Z

+# Azure Container Linux (ACL) is an immutable, sysext-based distro derived
+# from Flatcar.  This osutil is a standalone copy of MarinerOSUtil with
+# ACL-specific overrides so that future Azure-Linux changes do not
+# inadvertently affect the immutable ACL image.


The module header says ACL is "derived from Flatcar", but the PR description states ACL is derived from Azure Linux. This inconsistency makes it unclear what behavior/assumptions this OSUtil should follow (e.g., Flatcar/CoreOS vs Azure Linux/Mariner). Please align the comment (or the PR description) to the correct lineage to avoid future maintenance mistakes.

narrieta

lgtm

Signed-off-by: Mayank Singh <mayankfz@gmail.com>

mayankfz · 2026-04-08T11:26:13Z

@narrieta Now the waagent --version on ACL will look like - >

mayankfz requested review from ZhidongPeng, maddieford, nagworld9 and narrieta as code owners March 9, 2026 03:56

mayankfz force-pushed the mayansingh/add_acl_support branch 8 times, most recently from 66767af to 633b88d Compare March 11, 2026 12:36

mayankfz force-pushed the mayansingh/add_acl_support branch 5 times, most recently from c160224 to 205264c Compare March 20, 2026 07:20

nagworld9 reviewed Mar 24, 2026

View reviewed changes

Comment thread azurelinuxagent/common/future.py Outdated

Comment thread azurelinuxagent/ga/persist_firewall_rules.py Outdated

add support for Azure Container Linux

3d7596f

Signed-off-by: Mayank Singh <mayankfz@gmail.com>

mayankfz force-pushed the mayansingh/add_acl_support branch from d2451b5 to 3d7596f Compare March 26, 2026 03:44

Copilot AI review requested due to automatic review settings March 26, 2026 03:44

Copilot started reviewing on behalf of mayankfz March 26, 2026 03:45 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

Comment thread setup.py Outdated

Comment thread init/acl/waagent.service

Comment thread init/acl/waagent.service Outdated

Comment thread setup.py Outdated

Copilot AI review requested due to automatic review settings March 26, 2026 17:34

Copilot started reviewing on behalf of mayankfz March 26, 2026 17:35 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

Comment thread init/acl/waagent.service

Comment thread setup.py Outdated

mayankfz force-pushed the mayansingh/add_acl_support branch from 9038e1e to 16ad648 Compare March 26, 2026 18:33

incorporate review comments

5eee74d

Signed-off-by: Mayank Singh <mayankfz@gmail.com>

Copilot AI review requested due to automatic review settings March 26, 2026 18:46

Copilot AI review requested due to automatic review settings April 2, 2026 14:40

mayankfz dismissed nagworld9’s stale review via ead57b2 April 2, 2026 14:40

mayankfz force-pushed the mayansingh/add_acl_support branch from 7873258 to ead57b2 Compare April 2, 2026 14:40

Copilot started reviewing on behalf of mayankfz April 2, 2026 14:41 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

Comment thread azurelinuxagent/common/osutil/factory.py Outdated

Comment thread azurelinuxagent/common/osutil/factory.py Outdated

Comment thread setup.py Outdated

Comment thread azurelinuxagent/common/osutil/factory.py Outdated

incorporate review comments

fc501b4

Signed-off-by: Mayank Singh <mayankfz@gmail.com>

mayankfz force-pushed the mayansingh/add_acl_support branch from b91c062 to fc501b4 Compare April 2, 2026 15:22

narrieta reviewed Apr 2, 2026

View reviewed changes

Comment thread azurelinuxagent/common/osutil/factory.py Outdated

narrieta reviewed Apr 2, 2026

View reviewed changes

Comment thread setup.py Outdated

Copilot AI review requested due to automatic review settings April 3, 2026 06:17

mayankfz force-pushed the mayansingh/add_acl_support branch from 3120791 to 54fec45 Compare April 3, 2026 06:17

Copilot started reviewing on behalf of mayankfz April 3, 2026 06:18 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

Comment thread setup.py Outdated

mayankfz force-pushed the mayansingh/add_acl_support branch from 7608c5a to c1ce628 Compare April 3, 2026 06:34

narrieta reviewed Apr 3, 2026

View reviewed changes

Comment thread azurelinuxagent/common/osutil/factory.py Outdated

review comments

08be6ef

Signed-off-by: Mayank Singh <mayankfz@gmail.com>

Copilot AI review requested due to automatic review settings April 3, 2026 16:18

mayankfz force-pushed the mayansingh/add_acl_support branch from c1ce628 to 08be6ef Compare April 3, 2026 16:18

Copilot started reviewing on behalf of mayankfz April 3, 2026 16:19 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

narrieta reviewed Apr 3, 2026

View reviewed changes

update distro name for ACL as azurecontainerlinux in waagent

88fa537

Signed-off-by: Mayank Singh <mayankfz@gmail.com>

mayankfz force-pushed the mayansingh/add_acl_support branch from 9fa7056 to 88fa537 Compare April 8, 2026 11:25

Merge branch 'develop' into mayansingh/add_acl_support

2d5f456

narrieta approved these changes Apr 8, 2026

View reviewed changes

nagworld9 approved these changes Apr 8, 2026

View reviewed changes

nagworld9 merged commit f17af5a into Azure:develop Apr 8, 2026
14 checks passed

		# For Azure Container Linux, distro_name is "azurelinux" and distro_full_name is "Microsoft Azure Container Linux".
		if distro_name == "azurelinux" and distro_full_name == "Microsoft Azure Container Linux":

-    # For Azure Container Linux, distro_name is "azurelinux" and distro_full_name is "Microsoft Azure Container Linux".
-    if distro_name == "azurelinux" and distro_full_name == "Microsoft Azure Container Linux":
+    # For Azure Container Linux, distro_name is "azurelinux" and distro_full_name contains
+    # "Microsoft Azure Container Linux" (it may include additional version/build information).
+    normalized_distro_full_name = (distro_full_name or "").lower()
+    if distro_name == "azurelinux" and "azure container linux" in normalized_distro_full_name:

Conversation

mayankfz commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue

PR information

Quality of Code and Contribution Guidelines

Distro maintenance information, if applicable

Uh oh!

mayankfz commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

narrieta commented Apr 1, 2026

Uh oh!

mayankfz commented Apr 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

narrieta left a comment

Choose a reason for hiding this comment

Uh oh!

mayankfz commented Apr 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mayankfz commented Mar 9, 2026 •

edited

Loading

mayankfz commented Mar 24, 2026 •

edited

Loading