bin redundant role assignments

Author: jaredfholgate

modules/azure/storage.tf

@@ -71,19 +71,3 @@ resource "azurerm_role_assignment" "alz_storage_container_additional" {
   role_definition_name = "Storage Blob Data Owner"
   principal_id         = each.value
 }
-
-# These role assignments are a temporary addition to handle this issue in the Terraform CLI: https://github.com/hashicorp/terraform/issues/36595
-# They will be removed once the issue has been resolved
-resource "azurerm_role_assignment" "alz_storage_reader" {
-  for_each             = var.create_storage_account ? var.user_assigned_managed_identities : {}
-  scope                = azurerm_storage_account.alz[0].id
-  role_definition_name = "Reader"
-  principal_id         = azurerm_user_assigned_identity.alz[each.key].principal_id
-}
-
-resource "azurerm_role_assignment" "alz_storage_reader_additional" {
-  for_each             = var.create_storage_account ? var.additional_role_assignment_principal_ids : {}
-  scope                = azurerm_storage_account.alz[0].id
-  role_definition_name = "Reader"
-  principal_id         = each.value
-}

modules/file_manipulation/locals.intermediate_root_management_group.tf

@@ -17,7 +17,7 @@ locals {
 
 # Transform the intermediate root management group in the terraform architecture file to ensure it is marked as existing
 locals {
-  terraform_management_groups_non_root = local.is_terraform_iac_type ? [ for management_group in local.terraform_architecture.management_groups : management_group if management_group.parent_id != null ] : null
+  terraform_management_groups_non_root = local.is_terraform_iac_type ? [for management_group in local.terraform_architecture.management_groups : management_group if management_group.parent_id != null] : null
   terraform_intermediate_root_management_group_updated = local.is_terraform_iac_type ? merge(
     local.terraform_intermediate_root_management_group,
     {