fix duplicate entries

Author: jaredfholgate

alz/azuredevops/pipelines/bicep/templates/helpers/bicep-deploy.yaml

@@ -31,6 +31,7 @@ parameters:
 steps:
   - task: AzurePowerShell@5
     displayName: '$${{ parameters.displayName }}'
+    retryCountOnTaskFailure: 20
     inputs:
       azureSubscription: $${{ parameters.serviceConnection }}
       azurePowerShellVersion: 'LatestVersion'
@@ -165,7 +166,6 @@ steps:
             Write-Error "What-If validation failed: $($_.Exception.Message)"
             throw
           }
-
         } else {
           # Deployment Stack mode - actual deployment
           $stackParameters = @{
@@ -178,82 +178,57 @@ steps:
             Verbose               = $true
           }
 
-          $retryCount = 0
-          $retryMax = 20
-          $initialRetryDelay = 20
-          $retryDelayIncrement = 10
-          $finalSuccess = $false
-
-          while ($retryCount -lt $retryMax) {
-            if ($retryCount -gt 0) {
-              $retryDelay = $initialRetryDelay + ($retryCount * $retryDelayIncrement)
-              Write-Host "Retrying deployment stack after $retryDelay seconds..." -ForegroundColor Yellow
-              Start-Sleep -Seconds $retryDelay
-              Write-Host "Retry attempt $retryCount" -ForegroundColor Yellow
-            }
-
-            $result = $null
+          $result = $null
 
-            try {
-              switch ($deploymentType) {
-                "managementGroup" {
-                  $targetManagementGroupId = "$${{ parameters.managementGroupId }}"
-                  if ([string]::IsNullOrWhiteSpace($targetManagementGroupId)) {
-                    $targetManagementGroupId = (Get-AzContext).Tenant.TenantId
-                  }
-
-                  Write-Host "Creating Management Group Deployment Stack: $deploymentName" -ForegroundColor Cyan
-                  $result = New-AzManagementGroupDeploymentStack @stackParameters -ManagementGroupId $targetManagementGroupId -Location "$${{ parameters.location }}"
+          try {
+            switch ($deploymentType) {
+              "managementGroup" {
+                $targetManagementGroupId = "$${{ parameters.managementGroupId }}"
+                if ([string]::IsNullOrWhiteSpace($targetManagementGroupId)) {
+                  $targetManagementGroupId = (Get-AzContext).Tenant.TenantId
                 }
-                "subscription" {
-                  if (-not [string]::IsNullOrWhiteSpace("$${{ parameters.subscriptionId }}")) {
-                    Write-Host "Setting subscription context to: $${{ parameters.subscriptionId }}" -ForegroundColor Cyan
-                    Select-AzSubscription -SubscriptionId "$${{ parameters.subscriptionId }}" | Out-Null
-                  }
 
-                  Write-Host "Creating Subscription Deployment Stack: $deploymentName" -ForegroundColor Cyan
-                  $result = New-AzSubscriptionDeploymentStack @stackParameters -Location "$${{ parameters.location }}"
+                Write-Host "Creating Management Group Deployment Stack: $deploymentName" -ForegroundColor Cyan
+                $result = New-AzManagementGroupDeploymentStack @stackParameters -ManagementGroupId $targetManagementGroupId -Location "$${{ parameters.location }}"
+              }
+              "subscription" {
+                if (-not [string]::IsNullOrWhiteSpace("$${{ parameters.subscriptionId }}")) {
+                  Write-Host "Setting subscription context to: $${{ parameters.subscriptionId }}" -ForegroundColor Cyan
+                  Select-AzSubscription -SubscriptionId "$${{ parameters.subscriptionId }}" | Out-Null
                 }
-                "resourceGroup" {
-                  if (-not [string]::IsNullOrWhiteSpace("$${{ parameters.subscriptionId }}")) {
-                    Write-Host "Setting subscription context to: $${{ parameters.subscriptionId }}" -ForegroundColor Cyan
-                    Select-AzSubscription -SubscriptionId "$${{ parameters.subscriptionId }}" | Out-Null
-                  }
 
-                  Write-Host "Creating Resource Group Deployment Stack: $deploymentName" -ForegroundColor Cyan
-                  $result = New-AzResourceGroupDeploymentStack @stackParameters -ResourceGroupName "$${{ parameters.resourceGroupName }}"
-                }
-                default {
-                  Write-Error "Invalid deployment type: $deploymentType"
-                  throw "Invalid deployment type: $deploymentType"
-                }
+                Write-Host "Creating Subscription Deployment Stack: $deploymentName" -ForegroundColor Cyan
+                $result = New-AzSubscriptionDeploymentStack @stackParameters -Location "$${{ parameters.location }}"
               }
+              "resourceGroup" {
+                if (-not [string]::IsNullOrWhiteSpace("$${{ parameters.subscriptionId }}")) {
+                  Write-Host "Setting subscription context to: $${{ parameters.subscriptionId }}" -ForegroundColor Cyan
+                  Select-AzSubscription -SubscriptionId "$${{ parameters.subscriptionId }}" | Out-Null
+                }
 
-              if ($result.ProvisioningState -eq "Succeeded") {
-                $finalSuccess = $true
-                Write-Host ""
-                Write-Host "================================================" -ForegroundColor Green
-                Write-Host "✓ Deployment Stack Succeeded: $deploymentName" -ForegroundColor Green
-                Write-Host "================================================" -ForegroundColor Green
-                Write-Host ""
-                break
-              } else {
-                Write-Warning "Deployment stack finished with state: $($result.ProvisioningState)"
-                $retryCount++
+                Write-Host "Creating Resource Group Deployment Stack: $deploymentName" -ForegroundColor Cyan
+                $result = New-AzResourceGroupDeploymentStack @stackParameters -ResourceGroupName "$${{ parameters.resourceGroupName }}"
               }
-            } catch {
-              Write-Warning "Deployment stack failed with error: $($_.Exception.Message)"
-              $retryCount++
-
-              if ($retryCount -ge $retryMax) {
-                Write-Error "Deployment stack failed after $retryMax attempts"
-                throw
+              default {
+                Write-Error "Invalid deployment type: $deploymentType"
+                throw "Invalid deployment type: $deploymentType"
               }
             }
-          }
 
-          if (-not $finalSuccess) {
-            Write-Error "Deployment stack did not succeed after $retryMax attempts"
-            throw "Deployment stack did not succeed after $retryMax attempts"
+            if ($result.ProvisioningState -eq "Succeeded") {
+              $finalSuccess = $true
+              Write-Host ""
+              Write-Host "================================================" -ForegroundColor Green
+              Write-Host "✓ Deployment Stack Succeeded: $deploymentName" -ForegroundColor Green
+              Write-Host "================================================" -ForegroundColor Green
+              Write-Host ""
+              break
+            } else {
+              Write-Error "Deployment stack finished with state: $($result.ProvisioningState)"
+              exit 1
+            }
+          } catch {
+            Write-Error "Deployment stack failed with error: $($_.Exception.Message)"
+            exit 1
           }
         }

modules/file_manipulation/locals.bicep.tf

@@ -20,10 +20,10 @@ locals {
   }
 
   bicep_module_file_dynamic_replacements = { for flattened_result in flatten([ for key, value in local.starter_module_config.inputs :
-    [ for target in value.targets : {
+    [ for i, target in [ for t in value.targets : t if t.Destination == "Environment" ] : {
       key = key
       value = local.bicep_parameters[target.Name]
-    } if target.Destination == "Environment" ]
+    } if i == 0 ]
   ]) : flattened_result.key => flattened_result.value
   }