fix: local first deploy check

Author: jaredfholgate

alz/local/scripts-bicep/bicep-first-deployment-check.ps1

@@ -139,10 +139,9 @@ while ($retryCount -lt $retryMax) {
 
 if($finalSuccess -eq $false) {
     Write-Error "Deployment failed after $retryMax attempts..."
-    exit 1
 }
 
 Write-Host "<---------------------------------------------------------------------------->" -ForegroundColor DarkMagenta
 Write-Host "Completed $($whatIf ? "What If" : "Full") $displayName..." -ForegroundColor DarkMagenta
 Write-Host "<---------------------------------------------------------------------------->" -ForegroundColor DarkMagenta
-Write-Host ""
+Write-Host ""

alz/local/scripts/bicep-deploy.ps1

@@ -2,32 +2,16 @@ param(
     [string]$managementGroupId
 )
 
-# Read the int-root management group name from the bicepparam file
-$intRootParamFile = "templates/core/governance/mgmt-groups/int-root/main.bicepparam"
-if (Test-Path $intRootParamFile) {
-  $paramContent = Get-Content $intRootParamFile -Raw
-  if ($paramContent -match 'managementGroupName:\s*[''"](\w+)[''"]+') {
-    $intRootMgId = $matches[1]
-    Write-Host "Found int-root management group name in param file: $intRootMgId"
-  } else {
-    Write-Warning "Could not parse managementGroupName from $intRootParamFile, using default 'alz'"
-    $intRootMgId = "alz"
-  }
-} else {
-  Write-Warning "Int-root param file not found at $intRootParamFile, using default 'alz'"
-  $intRootMgId = "alz"
-}
-
 $managementGroups = Get-AzManagementGroup
-$intRootMg = $managementGroups | Where-Object { $_.Name -eq $intRootMgId }
+$managementGroup = $managementGroups | Where-Object { $_.Name -eq $managementGroupId }
 
 $firstDeployment = $true
 
-if ($null -eq $intRootMg) {
-  Write-Warning "Cannot find the $intRootMgId Management Group, so assuming this is the first deployment. We must skip checking some deployments since their dependent resources do not exist yet."
+if($null -eq $managementGroup) {
+  Write-Warning "Cannot find the $managementGroupId Management Group, so assuming this is the first deployment. We must skip checking some deployments since their dependent resources do not exist yet."
 } else {
-  Write-Host "Found the $intRootMgId Management Group, so assuming this is not the first deployment."
+  Write-Host "Found the $managementGroupId Management Group, so assuming this is not the first deployment."
   $firstDeployment = $false
 }
 
-return $firstDeployment
+return $firstDeployment

alz/local/scripts/bicep-first-deployment-check.ps1

@@ -62,4 +62,4 @@ New-Item -ItemType Directory -Path $targetFolderPath | Out-String | Write-Verbos
 Copy-Item -Path $sourceFolderPath -Destination $targetFolderPath -Recurse -Force | Out-String | Write-Verbose
 
 Remove-Item -Path $tempFolder -Force -Recurse
-Write-Host "Successfully copied the files from the release artifact to the target path $targetPath..."
+Write-Host "Successfully copied the files from the release artifact to the target path $targetPath..."

alz/local/scripts/bicep-on-demand-folder.ps1

@@ -60,5 +60,4 @@ if($deployApproved -ne "yes") {
     -firstRunWhatIf ${script_file.firstRunWhatIf} `
     -firstDeployment $isFirstDeployment `
 
-if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
-%{ endfor ~}
+%{ endfor ~}