Skip to content

chore: bump container tag#116

Merged
jaredfholgate merged 6 commits into
mainfrom
feat/bumpContainerTag
Dec 2, 2025
Merged

chore: bump container tag#116
jaredfholgate merged 6 commits into
mainfrom
feat/bumpContainerTag

Conversation

@matt-FFFFFF

@matt-FFFFFF matt-FFFFFF commented Nov 29, 2025

Copy link
Copy Markdown
Member

This pull request updates configuration variables related to container image builds for both Azure DevOps Agents and GitHub Runners. The main changes are to standardize the Dockerfile naming convention and update the default container image tag used across the deployment modules.

Container image configuration updates:

  • Changed the default container image tag for both Azure DevOps Agents and GitHub Runners from "39b9059" to "57a937f" in alz/azuredevops/variables.tf and alz/github/variables.tf. [1] [2]
  • Updated the default Dockerfile name from "dockerfile" to "Dockerfile" for agent, runner, and registry builds in alz/azuredevops/variables.tf, alz/github/variables.tf, and modules/azure/variables.tf. [1] [2] [3]

@jaredfholgate jaredfholgate marked this pull request as ready for review November 30, 2025 14:00
@jaredfholgate jaredfholgate added the PR: Safe to test 🧪 Enables running of End to End Tests label Nov 30, 2025
@jaredfholgate

Copy link
Copy Markdown
Member

The container build is failing with this error:
image

@jaredfholgate jaredfholgate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to fix the dockerfile for this issue. Seems the update is not going to be as easy as hoped.

@matt-FFFFFF

Copy link
Copy Markdown
Member Author

We'll need to fix the dockerfile for this issue. Seems the update is not going to be as easy as hoped.

I can sort this fairly easily. I'm surprised we need tools like netcat though! I'll add a workflow to the source repo to build the image to shift this left

@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs: Attention 👋 and removed Needs: Author Feedback 👂 Needs the author to provide feedback labels Nov 30, 2025
@matt-FFFFFF

matt-FFFFFF commented Nov 30, 2025

Copy link
Copy Markdown
Member Author

Actually thinking about it I can see netcat being useful to stream output.. I'll take a look

@jaredfholgate jaredfholgate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Attention 👋 PR: Safe to test 🧪 Enables running of End to End Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants