feat: update alz custom roles#117
Merged
jaredfholgate merged 3 commits intoDec 1, 2025
Merged
Conversation
jaredfholgate
added a commit
that referenced
this pull request
Dec 2, 2025
* Update readme * Initial changes for local version of bicep-avm * Updates to deploy local * Add logic for networktype and subscription id replacment * Adding subscription id replacement logic * Changes for new local config file for bicep-avm * Final updates for local bicep-avm deployment * Update error messaging * All changes requird for working Github implementation for bicep-avm * Add support for firstwhatif deployment to github * Initial azure devops files * Align permissiosn with github * Update permissions * Add location replacement logic * simplify deployment stack names and replacment managment group id * Update variable checks for network_type * Update logic for first deployment * Fix formatting * Add lint bypass * Add end-to-tests for bicep-avm * Add logic to exit for both bicep and bicep avm scripts if error * Extend retry duration * Add verbose logging * jared pedant changes * fixy mcfixington * fix e2e test * save changes * extract file manipulation and fix templating * more fixes * fixes for local * GitHub throttling * fix tests * fix e2e tests * fixes * i tests * fix bug * fix tf local * bug fix * fix templated files * reverse throttling * add option for debugging * bug fix * fix e2e tests * soft fail PowerShell module upgrade * fix tests * skip destory for avm bicep * unique deployment name * do not use runner groups in tests until we have a method to delete them * improve clean up jobs * loop cleanup * add time stamp capability * fix lin endings for linting * linting * linting * fix typo * engage brain * fix date format * randomise location to ensure a retry on a location specific issue can succeed * typo * simplify * remove canada * specify regions that have aci support and quota * fix regions list * fix scripts * remove eastus * Add nest MG test * fix first run check * fix logic... * improve clean up script * lookup sub * add provider no rbac for what if * feat: update alz custom roles (#117) * remove ARM deployment and stacks from TF * refine roles * clean up MGs * add check * trigger new run * fix what if perms * fix type for ps argument * add tenant role assignment for bicep * fix local name * refactor: rename tenant role assignment variables for bicep compatibility * docs and pipeline fixes * trigger a new run * try reverting role def * attempt to fix bootstrap perms issues * fix bug * revert variables * revert classic bicep perms * clean role defs * fix role def cleanup * typo * Fix spacing * revert classic what if change * stupid mistake... * fix linting --------- Co-authored-by: Jared Holgate <jaredholgate@microsoft.com> Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Copilot AI
pushed a commit
that referenced
this pull request
Dec 17, 2025
* Update readme * Initial changes for local version of bicep-avm * Updates to deploy local * Add logic for networktype and subscription id replacment * Adding subscription id replacement logic * Changes for new local config file for bicep-avm * Final updates for local bicep-avm deployment * Update error messaging * All changes requird for working Github implementation for bicep-avm * Add support for firstwhatif deployment to github * Initial azure devops files * Align permissiosn with github * Update permissions * Add location replacement logic * simplify deployment stack names and replacment managment group id * Update variable checks for network_type * Update logic for first deployment * Fix formatting * Add lint bypass * Add end-to-tests for bicep-avm * Add logic to exit for both bicep and bicep avm scripts if error * Extend retry duration * Add verbose logging * jared pedant changes * fixy mcfixington * fix e2e test * save changes * extract file manipulation and fix templating * more fixes * fixes for local * GitHub throttling * fix tests * fix e2e tests * fixes * i tests * fix bug * fix tf local * bug fix * fix templated files * reverse throttling * add option for debugging * bug fix * fix e2e tests * soft fail PowerShell module upgrade * fix tests * skip destory for avm bicep * unique deployment name * do not use runner groups in tests until we have a method to delete them * improve clean up jobs * loop cleanup * add time stamp capability * fix lin endings for linting * linting * linting * fix typo * engage brain * fix date format * randomise location to ensure a retry on a location specific issue can succeed * typo * simplify * remove canada * specify regions that have aci support and quota * fix regions list * fix scripts * remove eastus * Add nest MG test * fix first run check * fix logic... * improve clean up script * lookup sub * add provider no rbac for what if * feat: update alz custom roles (#117) * remove ARM deployment and stacks from TF * refine roles * clean up MGs * add check * trigger new run * fix what if perms * fix type for ps argument * add tenant role assignment for bicep * fix local name * refactor: rename tenant role assignment variables for bicep compatibility * docs and pipeline fixes * trigger a new run * try reverting role def * attempt to fix bootstrap perms issues * fix bug * revert variables * revert classic bicep perms * clean role defs * fix role def cleanup * typo * Fix spacing * revert classic what if change * stupid mistake... * fix linting --------- Co-authored-by: Jared Holgate <jaredholgate@microsoft.com> Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating ALZ custom role defs created
This pull request updates the Azure Landing Zones role definitions and assignments across Terraform, Bicep, GitHub, and local environments to standardize naming, expand permissions, and clarify role descriptions. The changes mainly address naming consistency, broaden the scope of custom roles, and refine permissions for management group operations.
Role Naming Standardization:
alz_managment_group_contributorandalz_managment_group_readertoalz_management_group_contributorandalz_management_group_readerfor consistency invariables.tffiles across all environments. [1] [2] [3] [4] [5] [6] [7] [8] [9]Role Definition and Permission Updates:
"*/read","Microsoft.Management/*", etc.), and added explicit exclusions to restrict resource group modifications. [1] [2]Role Description Improvements:
providerNoRbacvalidation flag with Bicep What If operations. [1] [2] [3] [4]Role Assignment Key Updates:
Permission Refinements for Subscription Reader Role: