Skip to content

feat: update alz custom roles#117

Merged
jaredfholgate merged 3 commits into
add-accelerator-configfrom
feat/update-alz-custom-roles
Dec 1, 2025
Merged

feat: update alz custom roles#117
jaredfholgate merged 3 commits into
add-accelerator-configfrom
feat/update-alz-custom-roles

Conversation

@jtracey93

@jtracey93 jtracey93 commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Updating ALZ custom role defs created

This pull request updates the Azure Landing Zones role definitions and assignments across Terraform, Bicep, GitHub, and local environments to standardize naming, expand permissions, and clarify role descriptions. The changes mainly address naming consistency, broaden the scope of custom roles, and refine permissions for management group operations.

Role Naming Standardization:

  • Renamed all instances of alz_managment_group_contributor and alz_managment_group_reader to alz_management_group_contributor and alz_management_group_reader for consistency in variables.tf files across all environments. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Role Definition and Permission Updates:

  • Expanded the actions for Bicep contributor and reader roles to use wildcard permissions (e.g., "*/read", "Microsoft.Management/*", etc.), and added explicit exclusions to restrict resource group modifications. [1] [2]
  • Removed several granular deployment and stack-related permissions from Terraform contributor and reader roles to streamline access. [1] [2] [3]

Role Description Improvements:

  • Updated descriptions for Bicep roles to clarify their expanded scope, including managing the management group hierarchy and governance resources, and added instructions for using the providerNoRbac validation flag with Bicep What If operations. [1] [2] [3] [4]

Role Assignment Key Updates:

  • Updated role assignment keys in Terraform and Bicep sections to match the new standardized role names, ensuring correct mapping for plan and apply operations. [1] [2] [3] [4]

Permission Refinements for Subscription Reader Role:

  • Adjusted the subscription reader role to align with the new management group hierarchy scope and added instructions for Bicep What If usage. Also, replaced granular write permissions with broader read and validation actions. [1] [2]

@jtracey93 jtracey93 marked this pull request as draft December 1, 2025 10:13
@jtracey93 jtracey93 changed the base branch from main to add-accelerator-config December 1, 2025 10:13
@jtracey93 jtracey93 marked this pull request as ready for review December 1, 2025 11:01

@jaredfholgate jaredfholgate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredfholgate jaredfholgate merged commit fccbb15 into add-accelerator-config Dec 1, 2025
4 checks passed
@jaredfholgate jaredfholgate deleted the feat/update-alz-custom-roles branch December 1, 2025 11:43
jaredfholgate added a commit that referenced this pull request Dec 2, 2025
* Update readme

* Initial changes for local version of bicep-avm

* Updates to deploy local

* Add logic for networktype and subscription id replacment

* Adding subscription id replacement logic

* Changes for new local config file for bicep-avm

* Final updates for local bicep-avm deployment

* Update error messaging

* All changes requird for working Github implementation for bicep-avm

* Add support for firstwhatif deployment to github

* Initial azure devops files

* Align permissiosn with github

* Update permissions

* Add location replacement logic

* simplify deployment stack names and replacment managment group id

* Update variable checks for network_type

* Update logic for first deployment

* Fix formatting

* Add lint bypass

* Add end-to-tests for bicep-avm

* Add logic to exit for both bicep and bicep avm scripts if error

* Extend retry duration

* Add verbose logging

* jared pedant changes

* fixy mcfixington

* fix e2e test

* save changes

* extract file manipulation and fix templating

* more fixes

* fixes for local

* GitHub throttling

* fix tests

* fix e2e tests

* fixes

* i tests

* fix bug

* fix tf local

* bug fix

* fix templated files

* reverse throttling

* add option for debugging

* bug fix

* fix e2e tests

* soft fail PowerShell module upgrade

* fix  tests

* skip destory for avm bicep

* unique deployment name

* do not use runner groups  in tests until we have a method to delete them

* improve clean up jobs

* loop cleanup

* add time stamp capability

* fix lin endings for linting

* linting

* linting

* fix typo

* engage brain

* fix date format

* randomise location to ensure a retry on a location specific issue can succeed

* typo

* simplify

* remove canada

* specify regions that have aci support and quota

* fix regions list

* fix scripts

* remove eastus

* Add nest MG test

* fix first run check

* fix logic...

* improve clean up script

* lookup sub

* add provider no rbac for what if

* feat: update alz custom roles (#117)

* remove ARM deployment and stacks from TF

* refine roles

* clean up MGs

* add check

* trigger new run

* fix what if perms

* fix type for ps argument

* add tenant role assignment for bicep

* fix local name

* refactor: rename tenant role assignment variables for bicep compatibility

* docs and pipeline fixes

* trigger a new run

* try reverting role def

* attempt to fix bootstrap perms issues

* fix bug

* revert variables

* revert classic bicep perms

* clean role defs

* fix role def cleanup

* typo

* Fix spacing

* revert classic what if change

* stupid mistake...

* fix linting

---------

Co-authored-by: Jared Holgate <jaredholgate@microsoft.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Copilot AI pushed a commit that referenced this pull request Dec 17, 2025
* Update readme

* Initial changes for local version of bicep-avm

* Updates to deploy local

* Add logic for networktype and subscription id replacment

* Adding subscription id replacement logic

* Changes for new local config file for bicep-avm

* Final updates for local bicep-avm deployment

* Update error messaging

* All changes requird for working Github implementation for bicep-avm

* Add support for firstwhatif deployment to github

* Initial azure devops files

* Align permissiosn with github

* Update permissions

* Add location replacement logic

* simplify deployment stack names and replacment managment group id

* Update variable checks for network_type

* Update logic for first deployment

* Fix formatting

* Add lint bypass

* Add end-to-tests for bicep-avm

* Add logic to exit for both bicep and bicep avm scripts if error

* Extend retry duration

* Add verbose logging

* jared pedant changes

* fixy mcfixington

* fix e2e test

* save changes

* extract file manipulation and fix templating

* more fixes

* fixes for local

* GitHub throttling

* fix tests

* fix e2e tests

* fixes

* i tests

* fix bug

* fix tf local

* bug fix

* fix templated files

* reverse throttling

* add option for debugging

* bug fix

* fix e2e tests

* soft fail PowerShell module upgrade

* fix  tests

* skip destory for avm bicep

* unique deployment name

* do not use runner groups  in tests until we have a method to delete them

* improve clean up jobs

* loop cleanup

* add time stamp capability

* fix lin endings for linting

* linting

* linting

* fix typo

* engage brain

* fix date format

* randomise location to ensure a retry on a location specific issue can succeed

* typo

* simplify

* remove canada

* specify regions that have aci support and quota

* fix regions list

* fix scripts

* remove eastus

* Add nest MG test

* fix first run check

* fix logic...

* improve clean up script

* lookup sub

* add provider no rbac for what if

* feat: update alz custom roles (#117)

* remove ARM deployment and stacks from TF

* refine roles

* clean up MGs

* add check

* trigger new run

* fix what if perms

* fix type for ps argument

* add tenant role assignment for bicep

* fix local name

* refactor: rename tenant role assignment variables for bicep compatibility

* docs and pipeline fixes

* trigger a new run

* try reverting role def

* attempt to fix bootstrap perms issues

* fix bug

* revert variables

* revert classic bicep perms

* clean role defs

* fix role def cleanup

* typo

* Fix spacing

* revert classic what if change

* stupid mistake...

* fix linting

---------

Co-authored-by: Jared Holgate <jaredholgate@microsoft.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants