Skip to content

feat: avm bicep#121

Merged
oZakari merged 17 commits into
mainfrom
feat-avm-bicep
Dec 12, 2025
Merged

feat: avm bicep#121
oZakari merged 17 commits into
mainfrom
feat-avm-bicep

Conversation

@jaredfholgate

@jaredfholgate jaredfholgate commented Dec 3, 2025

Copy link
Copy Markdown
Member

This pull request introduces several improvements and fixes to deployment automation and cleanup scripts, focusing on reliability, resource cleanup, and configuration consistency for Azure Landing Zones. The most important changes are grouped below by theme.

Deployment Reliability and Cleanup Enhancements:

  • Added robust cleanup logic to both Azure DevOps and GitHub Actions Bicep deployment scripts to remove all existing deployments before new deployments, preventing quota issues and ensuring clean environments. This includes batching deletions for efficiency and handling errors gracefully. (Fe13b2aaL199R199, [1] [2] [3] [4]
  • Improved retry logic in deployment scripts: reduced the maximum retry count for GitHub Actions from 20 to 10, and added clearer messaging for retry attempts in both Azure DevOps and GitHub Actions scripts. [1] [2] [3] [4]
  • Removed redundant retry loops in Azure DevOps Bicep deployment helper, now failing fast on deployment errors instead of repeated attempts. [1] [2]

Pipeline and Configuration Improvements:

  • Added the Bicep starter modules configuration to .config/ALZ-Powershell.config.json, enabling integration with the new Bicep accelerator repository.
  • Updated the default Bicep parameters file name to template-parameters.json for consistency across the codebase.
  • Updated Azure DevOps pipeline templates to ensure the Bicep installer helper runs at the correct stage in both CI and CD pipelines. [1] [2] [3] [4]
  • Removed unused variables from the file_manipulation module in the Terraform configuration.

Test and Script Reliability:

  • Improved the Azure resource cleanup script by ensuring the Azure CLI resource-graph extension is installed before querying, and switched to using Resource Graph queries for more efficient role assignment lookups and deletions. Also added error handling and messaging for role definition deletions. [1] [2] [3]

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

N/A

Breaking Changes

None

Testing Evidence

https://github.com/Azure/accelerator-bootstrap-modules/actions/runs/20165456393

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate jaredfholgate self-assigned this Dec 3, 2025
@jaredfholgate jaredfholgate added the PR: Safe to test 🧪 Enables running of End to End Tests label Dec 6, 2025
@jaredfholgate

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Safe to test 🧪 Enables running of End to End Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants