Merge pull request #774 from gambtho/telemetry-app-version

aksd: telemetry: stamp app version on every event

Author: illume

plugins/aks-desktop/src/telemetry/envelope.test.ts

@@ -65,6 +65,7 @@ describe('real Application Insights envelope', () => {
     expect(featureEnvelope.data.baseData.properties).toEqual({
       feature: 'headlamp.logs',
       status: 'opened',
+      appVersion: '1.0.0-test',
     });
     const errorEnvelope = serializedBatch.find(
       (envelope: { data?: { baseData?: { name?: string } } }) =>

plugins/aks-desktop/src/telemetry/index.test.ts

@@ -190,6 +190,26 @@ describe('initTelemetry', () => {
     });
   });
 
+  it('stamps initialized appVersion on a non-exception event', () => {
+    initTelemetry({
+      connectionString: 'InstrumentationKey=test',
+      installId: VALID_INSTALL_ID,
+      sessionProps: SESSION_PROPS,
+    });
+    trackEvent.mockClear();
+
+    trackFeature({ feature: 'headlamp.logs', status: 'opened' });
+
+    expect(trackEvent).toHaveBeenCalledWith({
+      name: 'headlamp.feature',
+      properties: {
+        appVersion: SESSION_PROPS.appVersion,
+        feature: 'headlamp.logs',
+        status: 'opened',
+      },
+    });
+  });
+
   it('is idempotent — second call does not re-construct AI', () => {
     initTelemetry({
       connectionString: 'InstrumentationKey=test',

plugins/aks-desktop/src/telemetry/index.ts

@@ -250,7 +250,7 @@ function send(event: PendingEvent): void {
   if (!ai) return;
   try {
     ai.trackEvent(
-      event.name === 'headlamp.exception' && initializedAppVersion
+      initializedAppVersion
         ? {
             ...event,
             properties: { ...event.properties, appVersion: initializedAppVersion },