Merge pull request #722 from skoeva/knip

aks-desktop: Clean up knip findings

Author: illume

knip.json

@@ -3,34 +3,28 @@
   "ignoreBinaries": [
     "make"
   ],
-  "ignore": [
-    "headlamp/.plugins/**",
-    "headlamp/app/resources/**"
-  ],
   "workspaces": {
     ".": {
       "entry": [
         "build/*.ts"
       ],
       "project": [
         "build/**/*.ts"
-      ],
-      "ignore": [
-        "build/download-az-cli.ts"
       ]
     },
     "plugins/aks-desktop": {
       "entry": [
-        "src/index.tsx"
+        "src/index.tsx",
+        "src/**/*.stories.{ts,tsx}",
+        "src/**/*.test.{ts,tsx}",
+        "src/**/*.guidepup.test.{ts,tsx}",
+        "src/utils/azure/**/*.ts"
       ],
       "project": [
         "src/**/*.{ts,tsx}"
       ],
       "ignore": [
-        "dist/**",
-        "src/**/*.d.ts",
-        "src/utils/test/*.test.ts",
-        "src/utils/test/run-tests.js"
+        "src/**/*.d.ts"
       ],
       "ignoreDependencies": [
         "@azure/arm-resourcegraph",
@@ -39,28 +33,14 @@
         "@iconify/react",
         "@monaco-editor/react",
         "@mui/material",
+        "@mui/utils",
+        "@storybook/react",
+        "@testing-library/jest-dom",
+        "@types/libsodium-wrappers",
+        "axe-core",
         "eslint-plugin-no-barrel-files",
-        "react-router-dom"
-      ],
-      "ignoreBinaries": [
-        "prettier"
-      ]
-    },
-    "plugins/ai-assistant": {
-      "entry": [
-        "src/index.tsx"
-      ],
-      "project": [
-        "src/**/*.{ts,tsx}"
-      ],
-      "ignore": [
-        "dist/**",
-        "src/**/*.d.ts"
-      ],
-      "ignoreDependencies": [
-        "@iconify/react",
-        "@monaco-editor/react",
-        "@mui/material",
+        "i18next",
+        "react-i18next",
         "react-router-dom"
       ],
       "ignoreBinaries": [

plugins/aks-desktop/src/components/CreateAKSProject/types.ts

@@ -188,16 +188,6 @@ export const AVAILABLE_ROLES = ['Admin', 'Writer', 'Reader'] as const;
 
 export type RoleType = (typeof AVAILABLE_ROLES)[number];
 
-// Role descriptions
-export const ROLE_DESCRIPTIONS: Record<RoleType, string> = {
-  Reader:
-    'Read-only access to most objects in a namespace. Cannot view roles, role bindings, or Secrets.',
-  Writer:
-    'Read/write access to most objects in a namespace. Cannot view or modify roles or role bindings. Can access Secrets and run Pods as any ServiceAccount in the namespace.',
-  Admin:
-    'Read/write access to most resources in a namespace. Can create roles and role bindings within the namespace. Cannot write to resource quota or the namespace itself.',
-};
-
 // Map UI role names to Azure RBAC role names
 export function mapUIRoleToAzureRole(uiRole: string): string {
   const roleMap: Record<string, string> = {

plugins/aks-desktop/src/components/CreateAKSProject/validators.ts

@@ -22,7 +22,7 @@ export const isValidObjectId = (objectId: string): boolean => {
 /**
  * Validates project name
  */
-export const validateProjectName = (projectName: string): ValidationResult => {
+const validateProjectName = (projectName: string): ValidationResult => {
   const trimmed = projectName.trim();
   const errors: string[] = [];
 
@@ -53,7 +53,7 @@ export const validateProjectName = (projectName: string): ValidationResult => {
 /**
  * Validates user assignments
  */
-export const validateAssignments = (assignments: UserAssignment[]): ValidationResult => {
+const validateAssignments = (assignments: UserAssignment[]): ValidationResult => {
   const errors: string[] = [];
 
   if (!Array.isArray(assignments)) {
@@ -256,7 +256,7 @@ export const validateBasicsStep = (
 /**
  * Validates the access step
  */
-export const validateAccessStep = (assignments: UserAssignment[]): ValidationResult => {
+const validateAccessStep = (assignments: UserAssignment[]): ValidationResult => {
   return validateAssignments(assignments);
 };
 

plugins/aks-desktop/src/components/DeployTab/hooks/useClusterDeployStatus.ts

@@ -4,10 +4,10 @@
 import { K8s, useTranslation } from '@kinvolk/headlamp-plugin/lib';
 import { useEffect, useState } from 'react';
 
-export const ANNOTATION_DEPLOYED_BY = 'aks-project/deployed-by';
-export const ANNOTATION_PIPELINE_REPO = 'aks-project/pipeline-repo';
-export const ANNOTATION_PIPELINE_RUN_URL = 'aks-project/pipeline-run-url';
-export const ANNOTATION_PIPELINE_WORKFLOW = 'aks-project/pipeline-workflow';
+const ANNOTATION_DEPLOYED_BY = 'aks-project/deployed-by';
+const ANNOTATION_PIPELINE_REPO = 'aks-project/pipeline-repo';
+const ANNOTATION_PIPELINE_RUN_URL = 'aks-project/pipeline-run-url';
+const ANNOTATION_PIPELINE_WORKFLOW = 'aks-project/pipeline-workflow';
 
 export type DeploymentProvenance = 'manual' | 'pipeline' | 'vscode' | 'unknown';
 

plugins/aks-desktop/src/components/DeployWizard/components/types.ts

@@ -4,13 +4,6 @@
 /**
  * Helper functions for resource management
  */
-export const bumpWithUnit = (current: string, step: number, unit: 'm' | 'Mi', min = 1): string => {
-  const numeric = parseInt(String(current).replace(/[^0-9]/g, ''), 10);
-  const safe = isNaN(numeric) ? 0 : numeric;
-  const next = Math.max(min, safe + step);
-  return `${next}${unit}`;
-};
-
 export const setFromInput = (
   raw: string,
   unit: 'm' | 'Mi',

plugins/aks-desktop/src/components/GitHubPipeline/constants.ts

@@ -16,12 +16,6 @@ export const COPILOT_SETUP_STEPS_PATH = '.github/workflows/copilot-setup-steps.y
 /** Path to the containerization agent config pushed by the setup PR. */
 export const AGENT_CONFIG_PATH = '.github/agents/containerization.agent.md';
 
-/**
- * GitHub bot usernames that may author PRs created by the Copilot Coding Agent.
- * Stored lowercase — always compare with `.toLowerCase()`.
- */
-export const COPILOT_BOT_USERS = new Set(['copilot-swe-agent[bot]', 'copilot[bot]', 'copilot']);
-
 /** Default image tag mandated in agent instructions. */
 export const DEFAULT_IMAGE_TAG = '1.0';
 

plugins/aks-desktop/src/components/GitHubPipeline/hooks/usePipelineAnnotationSync.ts

@@ -8,7 +8,7 @@ import type { PipelineDeploymentState } from '../types';
 
 export const ANNOTATION_PIPELINE_REPOS = 'aks-project/pipeline-repos';
 export const ANNOTATION_WORKLOAD_IDENTITY = 'aks-project/workload-identity-id';
-export const ANNOTATION_WORKLOAD_TENANT = 'aks-project/workload-identity-tenant';
+const ANNOTATION_WORKLOAD_TENANT = 'aks-project/workload-identity-tenant';
 
 const MERGE_PATCH_HEADERS = {
   Accept: 'application/json',

plugins/aks-desktop/src/components/Metrics/hooks/useCardMetrics.ts

@@ -33,12 +33,6 @@ const CACHE_TTL_MS = 5 * 60 * 1000; // 5 minutes
 /** Prometheus endpoint cache. */
 const promEndpointCache = new Map<string, string>();
 
-/** Clears all card metric caches */
-export function clearCardMetricsCaches(): void {
-  metricsCache.clear();
-  promEndpointCache.clear();
-}
-
 /** Result returned by {@link useCardMetrics}. */
 export interface UseCardMetricsResult {
   /** Metric values to be displayed on the MetricsCard. */