Fix Captcha styles, fix subscribe to product alignment, prevent custom styles from interfering with predefined widgets#2734
Fix Captcha styles, fix subscribe to product alignment, prevent custom styles from interfering with predefined widgets#2734Onatolich wants to merge 3 commits intofui/masterfrom
Conversation
…m styles from interfering with predefined widgets
|
@microsoft-github-policy-service agree company="Microsoft" |
src/components/products/product-subscribe/ko/runtime/product-subscribe.html
Outdated
Show resolved
Hide resolved
| padding: 7px 10px 5px !important; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Please, move all this to another file. Let's keep this for just imports.
There was a problem hiding this comment.
Why? This seems as an appropriate file to import all specific widget styles as well as defining global widget styles as well.
There was a problem hiding this comment.
This file is not redesign specific. Please, create a new one and place it there.
Also, why .fui-FluentProvider is specified 3 times? Can we specify it once as old widgets don't have this class at all.
There was a problem hiding this comment.
This file is not redesign specific. Please, create a new one and place it there.
Where do we put redesign specific files?
Also, why .fui-FluentProvider is specified 3 times?
Read a comment I written to it
There was a problem hiding this comment.
Where do we put
redesign specificfiles?
There is a folder named fui right next to this file.
Read a comment I written to it
Ok. My bad. Let's leave like this.
| [data-bind="widget: widget"] { | ||
| .button { | ||
| margin: 10px 20px 10px 0 !important; | ||
| padding: 9px 50px !important; |
There was a problem hiding this comment.
50px seems like a very big number. Are you sure?
There was a problem hiding this comment.
I believe I just copied what I had by default
There was a problem hiding this comment.
Just checked again, it is indeed 50px
| padding: 7px 10px 5px !important; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This file is not redesign specific. Please, create a new one and place it there.
Also, why .fui-FluentProvider is specified 3 times? Can we specify it once as old widgets don't have this class at all.
| .fui-FluentProvider.fui-FluentProvider.fui-FluentProvider { | ||
| .button { | ||
| margin: 10px 20px 10px 0; | ||
| padding: 9px 50px; |
There was a problem hiding this comment.
I am still sure this 50px value is wrong for the redesign. I know you took it from old widgets. Please, check designs and come up with proper spacing. For everything you specify here, not just this padding.
2 participants
No description provided.