fix(authService): always use redirect URI in lowercase in Auth Code with PKCE flow#2869
Open
J0F3 wants to merge 1 commit intoAzure:masterfrom
Open
fix(authService): always use redirect URI in lowercase in Auth Code with PKCE flow#2869J0F3 wants to merge 1 commit intoAzure:masterfrom
J0F3 wants to merge 1 commit intoAzure:masterfrom
Conversation
…e Code with PKCE flow fixes Azure#2868
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the OAuth 2.0 Auth Code with PKCE flow fails when the authorization server name contains uppercase letters, due to mismatched redirect URIs between the authorization and token requests.
Changes:
- Apply
.toLowerCase()to the redirect URI in the token exchange request to match the already-lowercased URI used in the authorization request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2868