Skip to content

Commit 43f17b2

Browse files
committed
Fix QA checklist: accept default terraform.tfstate, remove stale state path convention
QA still had the old stage-N-slug.tfstate checklist item (line 263) causing false CRITICAL on every stage. Updated to accept backend local {} and default terraform.tfstate. Updated remote state defaults to use relative paths (../stage-N-name/terraform.tfstate). Full audit confirmed no other stale references to .terraform-state/ or stage-N-slug convention remain in code, governance, or tests.
1 parent 95c7135 commit 43f17b2

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

azext_prototype/agents/builtin/qa_engineer.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,8 @@ def _encode_image(path: str) -> str:
260260
- [ ] providers.tf includes `required_version = ">= 1.9.0"`
261261
- [ ] main.tf does NOT contain terraform {} or provider {} blocks
262262
- [ ] All .tf files are syntactically valid HCL (properly opened/closed blocks)
263-
- [ ] Backend state file path follows convention: `stage-{N}-{slug}.tfstate`
263+
- [ ] Backend `backend "local" {}` is acceptable — each stage uses default `terraform.tfstate`
264+
in its own directory. Do NOT flag empty backend or `terraform.tfstate` as an issue.
264265
265266
### 8. CRITICAL: Scope Compliance
266267
- [ ] No resources created that are not listed in "Services in This Stage"
@@ -290,7 +291,7 @@ def _encode_image(path: str) -> str:
290291
- [ ] Cross-stage references use the **exact** output key names listed in the
291292
"Previously Generated Stages" section — do **NOT** flag keys as "non-standard"
292293
if they match what the upstream stage _actually_ exports
293-
- [ ] Remote state variable defaults match upstream backend paths exactly
294+
- [ ] Remote state variable defaults use relative paths: `../stage-N-name/terraform.tfstate`
294295
- [ ] **NO** unused `terraform_remote_state` data sources — every data source
295296
**MUST** have at least one output referenced in locals or resources
296297
- [ ] **NO** unused variables for state paths — if the data source is removed,

0 commit comments

Comments
 (0)