fix: Fixed collection of api tags (',' vs. ', ') (#853)

* Fixed collection of tags (',' vs. ', ')
* Added therories for api tags separated with and without whitespaces after the separator

Author: Horizon0156

src/ArmTemplates/Creator/TemplateCreators/TagAPITemplateCreator.cs

@@ -35,7 +35,7 @@ public List<TagApiTemplateResource> CreateTagAPITemplateResources(ApiConfig api,
             // create a tag/apis association resource for each tag in the config file
             List<TagApiTemplateResource> tagAPITemplates = new List<TagApiTemplateResource>();
             // tags is comma seperated list pf tags
-            string[] tagIDs = api.Tags.Split(", ");
+            string[] tagIDs = api.Tags.Split(",", System.StringSplitOptions.TrimEntries);
             foreach (string tagID in tagIDs)
             {
                 TagApiTemplateResource tagAPITemplate = this.CreateTagAPITemplateResource(tagID, api.Name, dependsOn);

src/ArmTemplates/Creator/TemplateCreators/TagTemplateCreator.cs

@@ -58,7 +58,7 @@ public Template CreateTagTemplate(CreatorParameters creatorConfig)
                 {
                     if (!api.Tags.IsNullOrEmpty())
                     {
-                        var apiTags = api.Tags.Split(",");
+                        var apiTags = api.Tags.Split(",", System.StringSplitOptions.TrimEntries);
 
                         foreach (var apiTag in apiTags)
                         {

tests/ArmTemplates.Tests/Creator/TemplateCreatorTests/TagTemplateCreatorTests.cs

@@ -21,7 +21,7 @@ namespace Microsoft.Azure.Management.ApiManagement.ArmTemplates.Tests.Creator.Te
     [Trait("Category", "Tag Template Creation")]
     public class TagTemplateCreatorTests
     {
-        CreatorParameters GenerateCreatorParameters(List<string> tagNames = null, List<string> apiTagNames = null)
+        CreatorParameters GenerateCreatorParameters(List<string> tagNames = null, string apiTagNames = null)
         {
             var creatorConfig = new CreatorParameters();
 
@@ -41,11 +41,10 @@ CreatorParameters GenerateCreatorParameters(List<string> tagNames = null, List<s
             if (!apiTagNames.IsNullOrEmpty())
             {
                 creatorConfig.Apis = new List<ApiConfig>();
-                var apiTagNamesString = string.Join(",", apiTagNames.ToArray());
 
                 var apiConfig = new ApiConfig
                 {
-                    Tags = apiTagNamesString
+                    Tags = apiTagNames
                 };
 
                 creatorConfig.Apis.Add(apiConfig);
@@ -54,20 +53,17 @@ CreatorParameters GenerateCreatorParameters(List<string> tagNames = null, List<s
             return creatorConfig;
         }
 
-        [Fact]
-        public void CreateTagTemplate_ShouldCreateTemplateFromCreatorConfig_GivenApiTagsAndConfigTags()
+        [Theory]
+        [InlineData("tag 1,tag2,api tag 3,api tag2")]
+        [InlineData("tag 1, tag2, api tag 3, api tag2")]
+        public void CreateTagTemplate_ShouldCreateTemplateFromCreatorConfig_GivenApiTagsAndConfigTags(string apiTagNames)
         {
             var tagTemplateCreator = new TagTemplateCreator(new TemplateBuilder());
 
             var tagNames = new List<string>()
             {
                 "tag 1", "tag2", "tag 3", "tag2"
             };
-            var apiTagNames = new List<string>()
-            {
-                "tag 1", "tag2", "api tag 3", "api tag2"
-            };
-
             var creatorConfig = this.GenerateCreatorParameters(tagNames, apiTagNames);
 
             var expectedTagsDictionary = new Dictionary<string, string>()
@@ -102,15 +98,12 @@ public void CreateTagTemplate_ShouldCreateTemplateFromCreatorConfig_GivenApiTags
             }
         }
 
-        [Fact]
-        public void CreateTagTemplate_ShouldCreateTemplateFromCreatorConfig_GivenOnlyApiTags()
+        [Theory]
+        [InlineData("tag 1,tag2,api tag 3,api tag2")]
+        [InlineData("tag 1, tag2, api tag 3, api tag2")]
+        public void CreateTagTemplate_ShouldCreateTemplateFromCreatorConfig_GivenOnlyApiTags(string apiTagNames)
         {
             var tagTemplateCreator = new TagTemplateCreator(new TemplateBuilder());
-
-            var apiTagNames = new List<string>()
-            {
-                "tag 1", "tag2", "api tag 3", "api tag2"
-            };
             var creatorConfig = this.GenerateCreatorParameters(apiTagNames: apiTagNames);
 
             var expectedTagsDictionary = new Dictionary<string, string>()
@@ -164,16 +157,13 @@ public void CreateTagTemplate_ShouldThrowEmptyResourceNameAfterSanitizingErrorMe
         {
             var tagTemplateCreator = new TagTemplateCreator(new TemplateBuilder());
 
-            var apiTagNames = new List<string>()
-            {
-                "tag 1", "tag2", "api tag 3", " "
-            };
+            var apiTagNames = "tag 1,tag2,api tag 3,";
             var creatorConfig = this.GenerateCreatorParameters(apiTagNames: apiTagNames);
 
 
             //act & assert
             Action act = () => tagTemplateCreator.CreateTagTemplate(creatorConfig);
-            act.Should().Throw<EmptyResourceNameException>().WithMessage(string.Format(ErrorMessages.EmptyResourceNameAfterSanitizingErrorMessage, " "));
+            act.Should().Throw<EmptyResourceNameException>().WithMessage(string.Format(ErrorMessages.EmptyResourceNameAfterSanitizingErrorMessage, string.Empty)); ;
         }
     }
 }