Skip to content

Commit 0cfef5b

Browse files
authored
fix azdev scan tests (#510)
1 parent 323a29d commit 0cfef5b

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

azdev/operations/tests/test_scan_and_mask.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ def test_scan_raw_string(self):
3434
self.assertEqual(len(result['scan_results']['raw_data']), 1)
3535
self.assertEqual(result['scan_results']['raw_data'][0]['secret_name'], 'AdditionalPattern')
3636

37-
regex_pattern1 = RegexPattern(r'(?<refine>[\w.%#+-]+)(%40|@)([a-z0-9.-]*.[a-z]{2,})', '000', 'EmailAddress')
38-
regex_pattern2 = RegexPattern('(?i)(?:^|[?;&])(?:dsas_secret|sig)=(?<refine>[0-9a-z\\/+%]{43,129}(?:=|%3d))', '001', 'LooseSasSecret')
37+
regex_pattern1 = RegexPattern(r'(?P<refine>[\w.%#+-]+)(%40|@)([a-z0-9.-]*.[a-z]{2,})', '000', 'EmailAddress')
38+
regex_pattern2 = RegexPattern('(?i)(?:^|[?;&])(?:dsas_secret|sig)=(?P<refine>[0-9a-z\\/+%]{43,129}(?:=|%3d))', '001', 'LooseSasSecret')
3939
with mock.patch("azdev.operations.secret._load_built_in_regex_patterns", return_value=(regex_pattern1, regex_pattern2)):
4040
test_data2 = "This is a test string with email fooabc@gmail.com and sas sv=2022-11-02&sr=c&sig=a9Y5mpQgKUiiPzHFNdDm53Na6UndTrNMCsRZd6b2oV4%3D"
4141
result = scan_secrets(data=test_data2)
@@ -86,8 +86,8 @@ def test_scan_file(self):
8686
self.assertEqual(len(result['scan_results'][simple_string_file]), 1)
8787
self.assertEqual(result['scan_results'][simple_string_file][0]['secret_name'], 'AdditionalPattern')
8888

89-
regex_pattern1 = RegexPattern(r'(?<refine>[\w.%#+-]+)(%40|@)([a-z0-9.-]*.[a-z]{2,})', '000', 'EmailAddress')
90-
regex_pattern2 = RegexPattern('(?i)(?:^|[?;&])(?:dsas_secret|sig)=(?<refine>[0-9a-z\\/+%]{43,129}(?:=|%3d))', '001', 'LooseSasSecret')
89+
regex_pattern1 = RegexPattern(r'(?P<refine>[\w.%#+-]+)(%40|@)([a-z0-9.-]*.[a-z]{2,})', '000', 'EmailAddress')
90+
regex_pattern2 = RegexPattern('(?i)(?:^|[?;&])(?:dsas_secret|sig)=(?P<refine>[0-9a-z\\/+%]{43,129}(?:=|%3d))', '001', 'LooseSasSecret')
9191
with mock.patch("azdev.operations.secret._load_built_in_regex_patterns", return_value=(regex_pattern1, regex_pattern2)):
9292
result = scan_secrets(file_path=info_json_file)
9393
self.assertTrue(result['secrets_detected'])
@@ -118,7 +118,7 @@ def test_scan_directory(self):
118118
custom_pattern = {
119119
"Include": [
120120
{
121-
"Pattern": r"(?<refine>[\w.%#+-]+)(%40|@)([a-z0-9.-]*.[a-z]{2,})",
121+
"Pattern": r"(?P<refine>[\w.%#+-]+)(%40|@)([a-z0-9.-]*.[a-z]{2,})",
122122
"Name": "EmailAddress"
123123
}
124124
]
@@ -153,7 +153,7 @@ def test_mask(self):
153153
custom_pattern = {
154154
"Include": [
155155
{
156-
"Pattern": r"(?<refine>[\w.%#+-]+)(%40|@)([a-z0-9.-]*.[a-z]{2,})",
156+
"Pattern": r"(?P<refine>[\w.%#+-]+)(%40|@)([a-z0-9.-]*.[a-z]{2,})",
157157
"Name": "EmailAddress"
158158
}
159159
]

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@
8787
'packaging',
8888
'tqdm',
8989
'wheel==0.30.0',
90-
'microsoft-security-utilities-secret-masker~=1.0.0b2'
90+
'microsoft-security-utilities-secret-masker~=1.0.0b4'
9191
],
9292
package_data={
9393
'azdev.config': ['*.*', 'cli_pylintrc', 'ext_pylintrc'],

0 commit comments

Comments
 (0)