Skip to content

Commit 64f4b0f

Browse files
authored
{CI} Fix cmdcov issue: Any name of a parameter has been tested, the parameter should be considered as passing the parameter test coverage. (#417)
* Update linter.py * update * Update HISTORY.rst
1 parent beb183f commit 64f4b0f

3 files changed

Lines changed: 9 additions & 5 deletions

File tree

HISTORY.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
33
Release History
44
===============
5+
0.1.58
6+
++++++
7+
* Fix cmdcov issue(#417): Any name of a parameter has been tested, the parameter should be considered as passing the parameter test coverage.
8+
59
0.1.57
610
++++++
711
* `azdev command-change meta-diff`: Remove duplicated meta-diff code and use azure-cli-diff-tool

azdev/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
# license information.
55
# -----------------------------------------------------------------------------
66

7-
__VERSION__ = '0.1.57'
7+
__VERSION__ = '0.1.58'

azdev/operations/linter/linter.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ def _detect_new_command(self, diff_index):
224224
for p, r in v['parameters'].items():
225225
if 'missing_parameter_test_coverage' in r['rule_exclusions']:
226226
exclude_parameters.append((c, p))
227-
elif 'rule_exclusions' in v:
227+
if 'rule_exclusions' in v:
228228
if 'missing_command_test_coverage' in v['rule_exclusions']:
229229
exclude_comands.append(c)
230230
_logger.debug('exclude_parameters: %s', exclude_parameters)
@@ -340,11 +340,11 @@ def _run_parameter_test_coverage(parameters, all_tested_command):
340340
if command in code and opt in code:
341341
flag = True
342342
break
343-
else:
344-
violations.append(f'Missing parameter test coverage: `{command} {opt}`')
345-
exec_state = False
346343
if flag:
347344
break
345+
else:
346+
violations.append(f'Missing parameter test coverage: `{command} {opt}`')
347+
exec_state = False
348348
if violations:
349349
violations.insert(0, 'Failed.')
350350
violations.extend([

0 commit comments

Comments
 (0)