Skip to content

Commit f9ab62b

Browse files
authored
Support resolve extension name in upcoming breaking change collection (#535)
* Use get_name_index function to resolve module name in upcoming breaking change collection * Bump version to 0.2.7 and update release history
1 parent dcc1fcf commit f9ab62b

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

HISTORY.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
33
Release History
44
===============
5+
0.2.7
6+
++++++
7+
* Support resolve extension name in upcoming breaking change collection
8+
59
0.2.6
610
++++++
711
* Bump `deepdiff` to 8.6.1 and `azure-cli-diff-tool` to 0.1.1

azdev/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
# license information.
55
# -----------------------------------------------------------------------------
66

7-
__VERSION__ = '0.2.6'
7+
__VERSION__ = '0.2.7'

azdev/operations/breaking_change/__init__.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
from azdev.operations.statistics import _create_invoker_and_load_cmds # pylint: disable=protected-access
1515
from azdev.utilities import require_azure_cli, display, heading, output, calc_selected_mod_names
16-
from azdev.utilities.path import calc_selected_modules
16+
from azdev.utilities.path import calc_selected_modules, get_name_index
1717

1818
# pylint: disable=no-else-return
1919

@@ -323,6 +323,7 @@ def collect_upcoming_breaking_changes(modules=None, target_version='NextWindow',
323323
require_azure_cli()
324324

325325
selected_modules = calc_selected_modules(modules, include_whl_extensions=include_whl_extensions)
326+
name_index = get_name_index(include_whl_extensions=include_whl_extensions)
326327
cli_mod_names = list(selected_modules['core'].keys()) + list(selected_modules['mod'].keys())
327328
ext_mod_names = list(selected_modules['ext'].keys())
328329

@@ -338,6 +339,9 @@ def collect_upcoming_breaking_changes(modules=None, target_version='NextWindow',
338339
cli_breaking_changes = _filter_breaking_changes(cli_breaking_changes, target_version)
339340
breaking_changes.extend(cli_breaking_changes)
340341
if ext_mod_names:
342+
# The user input extension name could be extension name or module name.
343+
# We need to convert the extension name to module name.
344+
ext_mod_names = [name_index.get(ext, ext) for ext in ext_mod_names]
341345
ext_breaking_changes = _handle_upcoming_breaking_changes(command_loader, ext_mod_names, 'pre_announce')
342346
breaking_changes.extend(ext_breaking_changes)
343347
breaking_changes = _group_breaking_change_items(breaking_changes, group_by_version)

0 commit comments

Comments
 (0)