Skip to content

Commit 19eb44d

Browse files
author
Christoph Butz
committed
[aks-preview] Fix OTLP live tests: remove rejected aksHTTPCustomFeatures header
The AzureMonitorAppMonitoringPreview capability is gated by subscription feature registration, not by a per-request AKSHTTPCustomFeatures header. The resource provider now rejects that header with '(BadRequest) Parameter aksHTTPCustomFeatures is not allowed', causing every OpenTelemetry @live_only scenario to fail before reaching its assertions. Removes '--aks-custom-headers AKSHTTPCustomFeatures=Microsoft.ContainerService/AzureMonitorAppMonitoringPreview' from the six OpenTelemetry live tests. Verified live that create/update with the OTLP flags succeeds once the header is dropped (feature registered on the subscription). The recorded app-monitoring tests are left unchanged, as they replay a cassette that still contains the header.
1 parent 2c524b8 commit 19eb44d

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16344,7 +16344,7 @@ def test_aks_create_with_azuremonitorlogs_and_opentelemetry(self, resource_group
1634416344
create_cmd = (
1634516345
'aks create --resource-group={resource_group} --name={name} --location={location} --ssh-key-value={ssh_key_value} --node-vm-size={node_vm_size} '
1634616346
'--enable-managed-identity --enable-azure-monitor-logs --enable-opentelemetry-logs-traces --opentelemetry-logs-traces-port-http=8080 --opentelemetry-logs-traces-port-grpc=8082 '
16347-
'--aks-custom-headers AKSHTTPCustomFeatures=Microsoft.ContainerService/AzureMonitorAppMonitoringPreview --output=json'
16347+
'--output=json'
1634816348
)
1634916349
self.cmd(create_cmd, checks=[
1635016350
self.check('provisioningState', 'Succeeded'),
@@ -16387,7 +16387,6 @@ def test_aks_update_with_azuremonitorlogs_and_opentelemetry(self, resource_group
1638716387
update_cmd = (
1638816388
'aks update --resource-group={resource_group} --name={name} --yes --output=json '
1638916389
'--enable-azure-monitor-logs --enable-opentelemetry-logs-traces --opentelemetry-logs-traces-port-http=9090 --opentelemetry-logs-traces-port-grpc=9092 '
16390-
'--aks-custom-headers AKSHTTPCustomFeatures=Microsoft.ContainerService/AzureMonitorAppMonitoringPreview'
1639116390
)
1639216391
self.cmd(update_cmd, checks=[
1639316392
self.check('provisioningState', 'Succeeded'),
@@ -16583,7 +16582,7 @@ def test_aks_create_with_azuremonitormetrics_and_opentelemetry(self, resource_gr
1658316582
create_cmd = (
1658416583
'aks create --resource-group={resource_group} --name={name} --location={location} --ssh-key-value={ssh_key_value} --node-vm-size={node_vm_size} '
1658516584
'--enable-managed-identity --enable-azure-monitor-metrics --enable-opentelemetry-metrics --opentelemetry-metrics-port-http=8080 --opentelemetry-metrics-port-grpc=8082 '
16586-
'--aks-custom-headers AKSHTTPCustomFeatures=Microsoft.ContainerService/AzureMonitorAppMonitoringPreview --output=json'
16585+
'--output=json'
1658716586
)
1658816587
self.cmd(create_cmd, checks=[
1658916588
self.check('provisioningState', 'Succeeded'),
@@ -16640,7 +16639,6 @@ def test_aks_update_with_azuremonitormetrics_and_opentelemetry(self, resource_gr
1664016639
update_cmd = (
1664116640
'aks update --resource-group={resource_group} --name={name} --yes '
1664216641
'--enable-azure-monitor-metrics --enable-opentelemetry-metrics --opentelemetry-metrics-port-http=9090 '
16643-
'--aks-custom-headers AKSHTTPCustomFeatures=Microsoft.ContainerService/AzureMonitorAppMonitoringPreview '
1664416642
'--output=json'
1664516643
)
1664616644

@@ -16766,7 +16764,7 @@ def test_aks_create_with_opentelemetry_deprecated_flag_aliases(self, resource_gr
1676616764
'--enable-managed-identity --enable-azure-monitor-logs --enable-azure-monitor-metrics '
1676716765
'--enable-opentelemetry-logs --opentelemetry-logs-port=8080 '
1676816766
'--enable-opentelemetry-metrics --opentelemetry-metrics-port=8081 '
16769-
'--aks-custom-headers AKSHTTPCustomFeatures=Microsoft.ContainerService/AzureMonitorAppMonitoringPreview --output=json'
16767+
'--output=json'
1677016768
)
1677116769
self.cmd(create_cmd, checks=[
1677216770
self.check('provisioningState', 'Succeeded'),
@@ -16945,7 +16943,7 @@ def test_aks_comprehensive_monitoring_integration(self, resource_group, resource
1694516943
'--enable-opentelemetry-logs-traces --opentelemetry-logs-traces-port-http=8080 --opentelemetry-logs-traces-port-grpc=8082 '
1694616944
'--enable-opentelemetry-metrics --opentelemetry-metrics-port-http=8081 --opentelemetry-metrics-port-grpc=8083 '
1694716945
'--enable-windows-recording-rules '
16948-
'--aks-custom-headers AKSHTTPCustomFeatures=Microsoft.ContainerService/AzureMonitorAppMonitoringPreview --output=json'
16946+
'--output=json'
1694916947
)
1695016948
self.cmd(create_cmd, checks=[
1695116949
self.check('provisioningState', 'Succeeded'),
@@ -17056,7 +17054,6 @@ def test_aks_comprehensive_monitoring_integration(self, resource_group, resource
1705617054
'aks update --resource-group={resource_group} --name={name} --yes --output=json '
1705717055
'--enable-opentelemetry-logs-traces --opentelemetry-logs-traces-port-http=9090 --opentelemetry-logs-traces-port-grpc=9092 '
1705817056
'--enable-opentelemetry-metrics --opentelemetry-metrics-port-http=9091 --opentelemetry-metrics-port-grpc=9093 '
17059-
'--aks-custom-headers AKSHTTPCustomFeatures=Microsoft.ContainerService/AzureMonitorAppMonitoringPreview'
1706017057
)
1706117058
self.cmd(update_cmd, checks=[
1706217059
self.check('provisioningState', 'Succeeded'),
@@ -17148,7 +17145,6 @@ def test_aks_comprehensive_monitoring_integration(self, resource_group, resource
1714817145
'--enable-opentelemetry-logs-traces --opentelemetry-logs-traces-port-http=7070 --opentelemetry-logs-traces-port-grpc=7072 '
1714917146
'--enable-opentelemetry-metrics --opentelemetry-metrics-port-http=7071 --opentelemetry-metrics-port-grpc=7073 '
1715017147
'--enable-windows-recording-rules '
17151-
'--aks-custom-headers AKSHTTPCustomFeatures=Microsoft.ContainerService/AzureMonitorAppMonitoringPreview'
1715217148
)
1715317149
self.cmd(update_cmd, checks=[
1715417150
self.check('provisioningState', 'Succeeded'),

0 commit comments

Comments
 (0)