Address review comments

Author: DomAyre

src/confcom/HISTORY.rst

@@ -3,6 +3,10 @@
 Release History
 ===============
 
+1.6.0
+++++++
+* Added confcom containers from_image command to generate container definitions from an image reference
+
 1.5.0
 ++++++
 * restored the behaviour of --upload-fragment in acifragmentgen to attach to first image in input

src/confcom/azext_confcom/_help.py

@@ -334,7 +334,7 @@
     "confcom containers from_image"
 ] = """
     type: command
-    short-summary: Create a Security Policy Container Definition based on a Radius app template.
+    short-summary: Create a Security Policy Container Definition based on an image reference.
 
     parameters:
         - name: --platform

src/confcom/azext_confcom/command/containers_from_image.py

@@ -8,5 +8,5 @@
 from azext_confcom.lib.containers import from_image as lib_containers_from_image
 
 
-def containers_from_image(image: str, platform: str) -> str:
-    return print(json.dumps(lib_containers_from_image(image, platform)))
+def containers_from_image(image: str, platform: str) -> None:
+    print(json.dumps(lib_containers_from_image(image, platform)))

src/confcom/azext_confcom/lib/containers.py

@@ -8,7 +8,7 @@
 from azext_confcom.lib.platform import ACI_MOUNTS
 
 
-def from_image(image: str, platform: str) -> str:
+def from_image(image: str, platform: str) -> dict:
 
     mounts = {
         "aci": [asdict(mount) for mount in ACI_MOUNTS],

src/confcom/azext_confcom/lib/images.py

@@ -32,7 +32,7 @@ def get_image_layers(image: str) -> list[str]:
     result = subprocess.run(
         [binary_path.as_posix(), "-d", "roothash", "-i", image],
         stdout=subprocess.PIPE,
-        stderr=subprocess.PIPE,
+        stderr=subprocess.DEVNULL,
         check=True,
         text=True,
     )