Skip to content

Commit 21e5ce8

Browse files
ShantingLiuCopilot
authored andcommitted
Update src/aks-preview/azext_aks_preview/managed_cluster_decorator.py
Address Copilot feedback: improve monitoring enablement detection - Use normalized addon list via _get_enable_addons() when available - Handle both string and list formats for enable_addons parameter - Also check --enable-azure-monitor-logs flag as alternative way to enable monitoring - Use CONST_MONITORING_ADDON_NAME_CAMELCASE for proper constant matching Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent 4670ade commit 21e5ce8

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -949,7 +949,10 @@ def get_container_network_logs(self, mc: ManagedCluster) -> Union[bool, None]:
949949
)
950950
# Check for monitoring addon - either being enabled via raw params or already enabled on mc
951951
enable_addons = self.raw_param.get("enable_addons") or ""
952-
monitoring_being_enabled = "monitoring" in enable_addons
952+
monitoring_being_enabled = (
953+
"monitoring" in enable_addons or
954+
bool(self.raw_param.get("enable_azure_monitor_logs"))
955+
)
953956
monitoring_already_enabled = (
954957
mc.addon_profiles and
955958
mc.addon_profiles.get("omsagent") and

0 commit comments

Comments
 (0)