Skip to content

Commit 2d3fb9a

Browse files
author
Suyash Choudhary
committed
Refactor code structure for improved readability and maintainability
1 parent dc7ccda commit 2d3fb9a

20 files changed

Lines changed: 207 additions & 508 deletions

File tree

src/storage-mover/azext_storage_mover/_params.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def load_arguments(self, _): # pylint: disable=unused-argument
7070
c.argument('source_uri', help='The URI which points to the S3-compatible source.')
7171
c.argument('source_type', arg_type=get_enum_type(['ALIBABA', 'DELL_EMC', 'GCS', 'IBM', 'MINIO', 'OTHER']),
7272
help='The source type of the S3WithHmac endpoint.')
73-
c.argument('other_source_type_description',
73+
c.argument('other_source_type_description', options_list=('--other-source-type-desc', '--other-source-type-description'),
7474
help='The description for other source type of S3WithHmac endpoint.')
7575

7676
for command in ['create-for-s3-with-hmac', 'update-for-s3-with-hmac']:

src/storage-mover/azext_storage_mover/aaz/latest/storage_mover/agent/_update.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,6 @@
1616
)
1717
class Update(AAZCommand):
1818
"""Update an Agent resource, which references a hybrid compute machine that can run jobs.
19-
20-
:example: agent update
21-
az storage-mover agent update -g {rg} -n {agent_name} --storage-mover-name {mover_name} --description 123
22-
23-
:example: add upload-limit-schedule
24-
az storage-mover agent update -g test-storagemover-rg2 -n agent2 --storage-mover-name teststoragemover2 --upload-limit-schedule "{weekly-recurrences:[{days:[Monday,Wednesday],start-time:{hour:10,minute:0},end-time:{hour:12,minute:30},limit-in-mbps:20}]}"
25-
26-
:example: add another weekly-recurrence to existing upload-limit-schedule list
27-
az storage-mover agent update -g test-storagemover-rg2 -n agent2 --storage-mover-name teststoragemover2 --upload-limit-schedule weekly-recurrences[1]="{days:[Tuesday,Thursday],start-time:{hour:10,minute:0},end-time:{hour:12,minute:30},limit-in-mbps:20}"
2819
"""
2920

3021
_aaz_info = {

src/storage-mover/azext_storage_mover/aaz/latest/storage_mover/connection/_create.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
7575
help="List of job definitions associated with this connection.",
7676
)
7777
_args_schema.private_link_service_id = AAZResourceIdArg(
78-
options=["--private-link-service-id"],
78+
options=["--private-link-service-id", "--pls-id"],
7979
arg_group="Properties",
8080
help="The PrivateLinkServiceId for the connection.",
8181
required=True,

src/storage-mover/azext_storage_mover/aaz/latest/storage_mover/connection/_update.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
8181
nullable=True,
8282
)
8383
_args_schema.private_link_service_id = AAZResourceIdArg(
84-
options=["--private-link-service-id"],
84+
options=["--private-link-service-id", "--pls-id"],
8585
arg_group="Properties",
8686
help="The PrivateLinkServiceId for the connection.",
8787
)

src/storage-mover/azext_storage_mover/aaz/latest/storage_mover/endpoint/_create.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
194194
s3_with_hmac.source_type = AAZStrArg(
195195
options=["source-type"],
196196
help="The source type of S3WithHmac endpoint.",
197-
enum={"BACKBLAZE": "BACKBLAZE", "CLOUDFLARE": "CLOUDFLARE", "GCS": "GCS", "IBM": "IBM", "MINIO": "MINIO"},
197+
enum={"ALIBABA": "ALIBABA", "DELL_EMC": "DELL_EMC", "GCS": "GCS", "IBM": "IBM", "MINIO": "MINIO", "OTHER": "OTHER"},
198198
)
199199
s3_with_hmac.source_uri = AAZStrArg(
200200
options=["source-uri"],
@@ -466,6 +466,7 @@ def _build_schema_on_200(cls):
466466
)
467467
identity.user_assigned_identities = AAZDictType(
468468
serialized_name="userAssignedIdentities",
469+
nullable=True,
469470
)
470471

471472
user_assigned_identities = cls._schema_on_200.identity.user_assigned_identities

src/storage-mover/azext_storage_mover/aaz/latest/storage_mover/endpoint/_list.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,7 @@ def _build_schema_on_200(cls):
197197
)
198198
identity.user_assigned_identities = AAZDictType(
199199
serialized_name="userAssignedIdentities",
200+
nullable=True,
200201
)
201202

202203
user_assigned_identities = cls._schema_on_200.value.Element.identity.user_assigned_identities

src/storage-mover/azext_storage_mover/aaz/latest/storage_mover/endpoint/_show.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ def _build_schema_on_200(cls):
195195
)
196196
identity.user_assigned_identities = AAZDictType(
197197
serialized_name="userAssignedIdentities",
198+
nullable=True,
198199
)
199200

200201
user_assigned_identities = cls._schema_on_200.identity.user_assigned_identities

src/storage-mover/azext_storage_mover/aaz/latest/storage_mover/endpoint/_update.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -417,6 +417,7 @@ def _build_schema_endpoint_read(cls, _schema):
417417
)
418418
identity.user_assigned_identities = AAZDictType(
419419
serialized_name="userAssignedIdentities",
420+
nullable=True,
420421
)
421422

422423
user_assigned_identities = _schema_endpoint_read.identity.user_assigned_identities

src/storage-mover/azext_storage_mover/aaz/latest/storage_mover/endpoint/_wait.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,7 @@ def _build_schema_on_200(cls):
194194
)
195195
identity.user_assigned_identities = AAZDictType(
196196
serialized_name="userAssignedIdentities",
197+
nullable=True,
197198
)
198199

199200
user_assigned_identities = cls._schema_on_200.identity.user_assigned_identities

src/storage-mover/azext_storage_mover/aaz/latest/storage_mover/endpoint/identity/_assign.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -377,6 +377,7 @@ def _build_schema_endpoint_read(cls, _schema):
377377
)
378378
identity.user_assigned_identities = AAZDictType(
379379
serialized_name="userAssignedIdentities",
380+
nullable=True,
380381
)
381382

382383
user_assigned_identities = _schema_endpoint_read.identity.user_assigned_identities

0 commit comments

Comments
 (0)