Commit 2f7b0ad
Wen Huang
fix: remove VMSS node-vm-size blocker and add VMs pool test
Address review comments:
1. Remove the InvalidArgumentValueError in update_auto_scaler_properties()
that blocked --node-vm-size for VMSS pools. This check was added when
--node-vm-size only supported VirtualMachines pools, but now VMSS
pools support VM size resize via rolling upgrade.
2. Add test case for VirtualMachines pool to verify update_vm_size() is
a no-op (VMs pools handle VM size via the autoscaler update path).
3. Add HISTORY.rst entry for the new feature.1 parent 05fc657 commit 2f7b0ad
3 files changed
Lines changed: 23 additions & 7 deletions
File tree
- src/aks-preview
- azext_aks_preview
- tests/latest
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1967 | 1967 | | |
1968 | 1968 | | |
1969 | 1969 | | |
1970 | | - | |
1971 | | - | |
1972 | | - | |
1973 | | - | |
1974 | | - | |
1975 | | - | |
1976 | | - | |
1977 | 1970 | | |
1978 | 1971 | | |
1979 | 1972 | | |
| |||
Lines changed: 22 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2691 | 2691 | | |
2692 | 2692 | | |
2693 | 2693 | | |
| 2694 | + | |
| 2695 | + | |
| 2696 | + | |
| 2697 | + | |
| 2698 | + | |
| 2699 | + | |
| 2700 | + | |
| 2701 | + | |
| 2702 | + | |
| 2703 | + | |
| 2704 | + | |
| 2705 | + | |
| 2706 | + | |
| 2707 | + | |
| 2708 | + | |
| 2709 | + | |
| 2710 | + | |
| 2711 | + | |
| 2712 | + | |
| 2713 | + | |
| 2714 | + | |
| 2715 | + | |
2694 | 2716 | | |
2695 | 2717 | | |
2696 | 2718 | | |
| |||
0 commit comments