Skip to content

Commit 3cc5da8

Browse files
{Keyvault-preview} Remove __import__('pkg_resources').declare_namespace(__name__) (#9593)
* feature: remove pkg_resource usage * fix: remove extra plus signs * fix: remove unused imports * fix: remove unused import * fix: change logging placeholders * fix: fix conditional logic
1 parent c9fdae3 commit 3cc5da8

7 files changed

Lines changed: 12 additions & 10 deletions

File tree

src/keyvault-preview/HISTORY.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
33
Release History
44
===============
5+
6+
1.0.2
7+
++++++
8+
* Remove `__import__('pkg_resources').declare_namespace(__name__)` to fix the namespace package issue.
9+
510
1.0.1
611
++++++
712
* Specify minCliCoreVersion

src/keyvault-preview/azext_keyvault_preview/__init__.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class KeyVaultCommandsLoader(AzCommandsLoader):
1414
def __init__(self, cli_ctx=None):
1515
from azure.cli.core.commands import CliCommandType
1616
from ._client_factory import keyvault_mgmt_client_factory
17-
from azure.cli.command_modules.keyvault._command_type import KeyVaultCommandGroup, KeyVaultArgumentContext
17+
from azure.cli.command_modules.keyvault._command_type import KeyVaultCommandGroup
1818

1919
register_resource_type('latest', CUSTOM_MGMT_KEYVAULT, '2021-12-01-preview')
2020

@@ -27,8 +27,7 @@ def __init__(self, cli_ctx=None):
2727
cli_ctx=cli_ctx,
2828
resource_type=CUSTOM_MGMT_KEYVAULT,
2929
custom_command_type=keyvault_custom,
30-
command_group_cls=KeyVaultCommandGroup,
31-
argument_context_cls=KeyVaultArgumentContext)
30+
command_group_cls=KeyVaultCommandGroup)
3231

3332
def load_command_table(self, args):
3433
from .commands import load_command_table

src/keyvault-preview/azext_keyvault_preview/_validators.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def validate_resource_group_name(cmd, ns):
1717

1818
vault_name = getattr(ns, 'vault_name', None)
1919
hsm_name = getattr(ns, 'hsm_name', None)
20-
if 'keyvault update-hsm' in cmd.name or 'keyvault region':
20+
if 'keyvault update-hsm' in cmd.name or 'keyvault region' in cmd.name:
2121
hsm_name = getattr(ns, 'name', None)
2222

2323
if vault_name and hsm_name:

src/keyvault-preview/azext_keyvault_preview/commands.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Licensed under the MIT License. See License.txt in the project root for license information.
44
# --------------------------------------------------------------------------------------------
55
from azure.cli.core.commands import CliCommandType
6-
from ._client_factory import is_azure_stack_profile, cf_mhsm, cf_mhsm_region
6+
from ._client_factory import cf_mhsm, cf_mhsm_region
77
from .profiles import CUSTOM_MGMT_KEYVAULT
88

99

src/keyvault-preview/azext_keyvault_preview/custom.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def add_hsm_region(cmd, client, resource_group_name, name, region_name, no_wait=
5555
existing_regions = hsm.properties.regions or []
5656
for existing_region in existing_regions:
5757
if region_name == existing_region.name:
58-
logger.warning("{} has already existed".format(region_name))
58+
logger.warning("%s has already existed", region_name)
5959
return hsm
6060
existing_regions.append(MHSMGeoReplicatedRegion(name=region_name))
6161
hsm.properties.regions = existing_regions
@@ -75,5 +75,5 @@ def remove_hsm_region(client, resource_group_name, name, region_name, no_wait=Fa
7575
return sdk_no_wait(no_wait, client.begin_update,
7676
resource_group_name=resource_group_name,
7777
name=name, parameters=hsm)
78-
logger.warning("{} doesn't exist".format(region_name))
78+
logger.warning("%s doesn't exist", region_name)
7979
return hsm

src/keyvault-preview/azext_keyvault_preview/vendored_sdks/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,3 @@
22
# Copyright (c) Microsoft Corporation. All rights reserved.
33
# Licensed under the MIT License. See License.txt in the project root for license information.
44
# --------------------------------------------------------------------------------------------
5-
6-
__import__('pkg_resources').declare_namespace(__name__)

src/keyvault-preview/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from setuptools import setup, find_packages
1111

1212
# HISTORY.rst entry.
13-
VERSION = '1.0.1'
13+
VERSION = '1.0.2'
1414

1515
# The full list of classifiers is available at
1616
# https://pypi.python.org/pypi?%3Aaction=list_classifiers

0 commit comments

Comments
 (0)